Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1389)

Side by Side Diff: runtime/vm/message_handler.cc

Issue 1818883003: Fix --trace-isolates VM crash. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/message_handler.h" 5 #include "vm/message_handler.h"
6 6
7 #include "vm/dart.h" 7 #include "vm/dart.h"
8 #include "vm/lockers.h" 8 #include "vm/lockers.h"
9 #include "vm/object.h" 9 #include "vm/object.h"
10 #include "vm/object_store.h" 10 #include "vm/object_store.h"
(...skipping 364 matching lines...) Expand 10 before | Expand all | Expand 10 after
375 if (ShouldPauseOnExit(status)) { 375 if (ShouldPauseOnExit(status)) {
376 // Still paused. 376 // Still paused.
377 ASSERT(oob_queue_->IsEmpty()); 377 ASSERT(oob_queue_->IsEmpty());
378 task_ = NULL; // No task in queue. 378 task_ = NULL; // No task in queue.
379 return; 379 return;
380 } else { 380 } else {
381 PausedOnExitLocked(&ml, false); 381 PausedOnExitLocked(&ml, false);
382 } 382 }
383 } 383 }
384 if (FLAG_trace_isolates) { 384 if (FLAG_trace_isolates) {
385 if (status != kOK && isolate() != NULL) { 385 if (status != kOK && thread() != NULL) {
386 const Error& error = Error::Handle(thread()->sticky_error()); 386 const Error& error = Error::Handle(thread()->sticky_error());
387 OS::Print("[-] Stopping message handler (%s):\n" 387 OS::Print("[-] Stopping message handler (%s):\n"
388 "\thandler: %s\n" 388 "\thandler: %s\n"
389 "\terror: %s\n", 389 "\terror: %s\n",
390 MessageStatusString(status), name(), error.ToCString()); 390 MessageStatusString(status), name(), error.ToCString());
391 } else { 391 } else {
392 OS::Print("[-] Stopping message handler (%s):\n" 392 OS::Print("[-] Stopping message handler (%s):\n"
393 "\thandler: %s\n", 393 "\thandler: %s\n",
394 MessageStatusString(status), name()); 394 MessageStatusString(status), name());
395 } 395 }
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
526 handler_->oob_message_handling_allowed_ = false; 526 handler_->oob_message_handling_allowed_ = false;
527 } 527 }
528 528
529 529
530 MessageHandler::AcquiredQueues::~AcquiredQueues() { 530 MessageHandler::AcquiredQueues::~AcquiredQueues() {
531 ASSERT(handler_ != NULL); 531 ASSERT(handler_ != NULL);
532 handler_->oob_message_handling_allowed_ = true; 532 handler_->oob_message_handling_allowed_ = true;
533 } 533 }
534 534
535 } // namespace dart 535 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698