src/debug/arm/debug-arm.cc - Issue 1818873003: [Interpreter] Adds support to fetch return value on break at return.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/arm/debug-arm.cc

Issue 1818873003: [Interpreter] Adds support to fetch return value on break at return. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fixed the bugs in earlier implementation. Changed full-codegen to match ignition for fetching the r… Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/debug/arm/debug-arm.cc

diff --git a/src/debug/arm/debug-arm.cc b/src/debug/arm/debug-arm.cc

index 99a555de9c5800e4deeb7d7d80db2a7025d40d7a..c417e2703698823ab436b301ec6f9f6e49a05262 100644

--- a/src/debug/arm/debug-arm.cc

+++ b/src/debug/arm/debug-arm.cc

@@ -83,7 +83,9 @@ void DebugCodegen::GenerateDebugBreakStub(MacroAssembler* masm,

if (mode == SAVE_RESULT_REGISTER) __ push(r0);

- __ mov(r0, Operand::Zero()); // no arguments

+ // One argument. The hole in FCG. Value of accumulator in interpreter.

+ __ mov(r0, Operand(1));

+ __ Push(masm->isolate()->factory()->the_hole_value());

__ mov(r1,

Operand(ExternalReference(

Runtime::FunctionForId(Runtime::kDebugBreak), masm->isolate())));

« no previous file with comments | « no previous file | src/debug/arm64/debug-arm64.cc » ('j') | src/debug/arm64/debug-arm64.cc » ('J')