Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: src/debug/arm/debug-arm.cc

Issue 1818873003: [Interpreter] Adds support to fetch return value on break at return. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixed the bugs in earlier implementation. Changed full-codegen to match ignition for fetching the r… Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/debug/arm64/debug-arm64.cc » ('j') | src/debug/arm64/debug-arm64.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 // Load padding words on stack. 76 // Load padding words on stack.
77 __ mov(ip, Operand(Smi::FromInt(LiveEdit::kFramePaddingValue))); 77 __ mov(ip, Operand(Smi::FromInt(LiveEdit::kFramePaddingValue)));
78 for (int i = 0; i < LiveEdit::kFramePaddingInitialSize; i++) { 78 for (int i = 0; i < LiveEdit::kFramePaddingInitialSize; i++) {
79 __ push(ip); 79 __ push(ip);
80 } 80 }
81 __ mov(ip, Operand(Smi::FromInt(LiveEdit::kFramePaddingInitialSize))); 81 __ mov(ip, Operand(Smi::FromInt(LiveEdit::kFramePaddingInitialSize)));
82 __ push(ip); 82 __ push(ip);
83 83
84 if (mode == SAVE_RESULT_REGISTER) __ push(r0); 84 if (mode == SAVE_RESULT_REGISTER) __ push(r0);
85 85
86 __ mov(r0, Operand::Zero()); // no arguments 86 // One argument. The hole in FCG. Value of accumulator in interpreter.
87 __ mov(r0, Operand(1));
88 __ Push(masm->isolate()->factory()->the_hole_value());
87 __ mov(r1, 89 __ mov(r1,
88 Operand(ExternalReference( 90 Operand(ExternalReference(
89 Runtime::FunctionForId(Runtime::kDebugBreak), masm->isolate()))); 91 Runtime::FunctionForId(Runtime::kDebugBreak), masm->isolate())));
90 92
91 CEntryStub ceb(masm->isolate(), 1); 93 CEntryStub ceb(masm->isolate(), 1);
92 __ CallStub(&ceb); 94 __ CallStub(&ceb);
93 95
94 if (FLAG_debug_code) { 96 if (FLAG_debug_code) {
95 for (int i = 0; i < kNumJSCallerSaved; i++) { 97 for (int i = 0; i < kNumJSCallerSaved; i++) {
96 Register reg = {JSCallerSavedCode(i)}; 98 Register reg = {JSCallerSavedCode(i)};
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 149
148 150
149 const bool LiveEdit::kFrameDropperSupported = true; 151 const bool LiveEdit::kFrameDropperSupported = true;
150 152
151 #undef __ 153 #undef __
152 154
153 } // namespace internal 155 } // namespace internal
154 } // namespace v8 156 } // namespace v8
155 157
156 #endif // V8_TARGET_ARCH_ARM 158 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/debug/arm64/debug-arm64.cc » ('j') | src/debug/arm64/debug-arm64.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698