Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1818543002: Add dev_compiler to the SDK build process. (Closed)

Created:
4 years, 9 months ago by Paul Berry
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add dev_compiler to the SDK build process. Also update DEPS to bring the latest dev_compiler into the SDK. This is a second attempt at https://codereview.chromium.org/1777173003, with the following fixes: - Added .bat files for Windows. - Added missing dependency: create_sdk_internal depends on dartdevc.dart.snapshot. - Used pkg_files.stamp to note the source code dependency for dartdevc, so that we don't go beyond xcodebuild's input length limit. R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/b73e02db49a237e8e9031952c19eb74e9cd8feb8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -22 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M create_sdk.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M dart.gyp View 2 chunks +8 lines, -0 lines 0 comments Download
A + sdk/bin/dartdevc View 3 chunks +3 lines, -3 lines 0 comments Download
A + sdk/bin/dartdevc.bat View 3 chunks +2 lines, -6 lines 0 comments Download
A + sdk/bin/dartdevc_sdk View 2 chunks +2 lines, -2 lines 0 comments Download
A + sdk/bin/dartdevc_sdk.bat View 1 chunk +1 line, -1 line 0 comments Download
M tools/create_sdk.py View 3 chunks +4 lines, -2 lines 0 comments Download
A + utils/dartdevc/dartdevc.gyp View 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
Tested on Windows, Mac, and Linux.
4 years, 9 months ago (2016-03-18 19:59:38 UTC) #2
Jennifer Messerly
lgtm! Thank you soooo much!
4 years, 9 months ago (2016-03-18 20:02:47 UTC) #3
Paul Berry
4 years, 9 months ago (2016-03-18 20:09:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b73e02db49a237e8e9031952c19eb74e9cd8feb8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698