Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1777173003: Add dev_compiler to the SDK build process. (Closed)

Created:
4 years, 9 months ago by Paul Berry
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org, keertip
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add dev_compiler to the SDK build process. Also update DEPS to bring the latest dev_compiler into the SDK. R=jmesserly@google.com, whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/2ddf2448195b0489ffa9b4245c123dacb0230848

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rename dev_compiler -> dartdevc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -15 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M create_sdk.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M dart.gyp View 1 2 chunks +8 lines, -0 lines 0 comments Download
A + sdk/bin/dartdevc View 1 3 chunks +3 lines, -3 lines 0 comments Download
A + sdk/bin/dartdevc_sdk View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/create_sdk.py View 1 3 chunks +4 lines, -2 lines 0 comments Download
A + utils/dartdevc/dartdevc.gyp View 1 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Paul Berry
4 years, 9 months ago (2016-03-10 23:13:08 UTC) #2
Jennifer Messerly
https://codereview.chromium.org/1777173003/diff/1/tools/create_sdk.py File tools/create_sdk.py (right): https://codereview.chromium.org/1777173003/diff/1/tools/create_sdk.py#newcode22 tools/create_sdk.py:22: # ......dev_compiler Nice! The name here is supposed to ...
4 years, 9 months ago (2016-03-11 17:20:14 UTC) #3
Bill Hesse
LGTM. Why not change the name of the snapshot to dartdevc as well?
4 years, 9 months ago (2016-03-11 21:51:23 UTC) #4
Paul Berry
Renamed dev_analyzer to dartdevc. PTAL.
4 years, 9 months ago (2016-03-17 16:39:36 UTC) #5
Bill Hesse
On 2016/03/17 16:39:36, Paul Berry wrote: > Renamed dev_analyzer to dartdevc. PTAL. Still looks good ...
4 years, 9 months ago (2016-03-17 16:47:24 UTC) #6
Jennifer Messerly
lgtm!
4 years, 9 months ago (2016-03-17 16:56:40 UTC) #7
Paul Berry
4 years, 9 months ago (2016-03-17 18:14:40 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
2ddf2448195b0489ffa9b4245c123dacb0230848 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698