third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp - Issue 1818473002: [DevTools] Move getInternalProperties to native

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

Issue 1818473002: [DevTools] Move getInternalProperties to native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-call-function-on

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js ('k') | third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

index 46b0cdc848352797175c5fa0c95d4e1866ea3664..b269a5a39b8ed0bdbcba6a3407bd34d173a6d608 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

@@ -706,9 +706,11 @@ void V8DebuggerAgentImpl::getGeneratorObjectDetails(ErrorString* errorString, co

v8::Context::Scope contextScope(context);

v8::Local<v8::Object> object;

- v8::Local<v8::Value> value = injectedScript->findObject(*remoteId);

- if (value.IsEmpty() || !value->IsObject() || !value->ToObject(context).ToLocal(&object)) {

- *errorString = "Could not find object with given id";

+ v8::Local<v8::Value> value;

+ if (!injectedScript->findObject(errorString, *remoteId, &value))

+ return;

+ if (!value->IsObject() || !value->ToObject(context).ToLocal(&object)) {

+ *errorString = "Could not find object with type Object and given id";

dgozman 2016/03/18 20:52:21 Improve this error string.

kozy 2016/03/18 22:53:16 Done.

return;

}