[DevTools] Move getInternalProperties to native

third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/v8_inspector/V8DebuggerAgentImpl.h"
 
 #include "platform/inspector_protocol/String16.h"
 #include "platform/inspector_protocol/Values.h"
 #include "platform/v8_inspector/IgnoreExceptionsScope.h"
 #include "platform/v8_inspector/InjectedScript.h"
@@ skipping 688 matching lines @@
         return;
     InjectedScript* injectedScript = m_injectedScriptManager->findInjectedScript(errorString, remoteId.get());
     if (!injectedScript)
         return;
 
     v8::HandleScope scope(m_isolate);
     v8::Local<v8::Context> context = injectedScript->context();
     v8::Context::Scope contextScope(context);
 
     v8::Local<v8::Object> object;
-    v8::Local<v8::Value> value = injectedScript->findObject(*remoteId);
-    if (value.IsEmpty() || !value->IsObject() || !value->ToObject(context).ToLocal(&object)) {
-        *errorString = "Could not find object with given id";
+    v8::Local<v8::Value> value;
+    if (!injectedScript->findObject(errorString, *remoteId, &value))
+        return;
+    if (!value->IsObject() || !value->ToObject(context).ToLocal(&object)) {
+        *errorString = "Could not find object with type Object and given id";

[dgozman, 2016/03/18 20:52:21]

Improve this error string.

[kozy, 2016/03/18 22:53:16]

Done.

         return;
     }
 
     v8::Local<v8::Object> detailsObject;
     v8::Local<v8::Value> detailsValue = debugger().generatorObjectDetails(object);
     if (!detailsValue->IsObject() || !detailsValue->ToObject(context).ToLocal(&detailsObject)) {
         *errorString = "Internal error";
         return;
     }
 
@@ skipping 850 matching lines @@
     m_scripts.clear();
     m_blackboxedPositions.clear();
     m_breakpointIdToDebuggerBreakpointIds.clear();
     resetAsyncCallTracker();
     m_promiseTracker->clear();
     if (m_frontend)
         m_frontend->globalObjectCleared();
 }
 
 } // namespace blink