Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1818403003: Don't ever attempt to upload credit cards whose numbers match. (Closed)

Created:
4 years, 9 months ago by Justin Donnelly
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Don't ever attempt to upload credit cards whose numbers match. Previously, we were using the logic derived from local card handling where if the name or expiration date was different we would offer to save a card even if we already had an autofill entry with that exact card number. But in the case of upload, this will never succeed. BUG=596515 Review URL: https://codereview.chromium.org/1808613004 Cr-Commit-Position: refs/heads/master@{#381974} (cherry picked from commit ee7e2c11cc024f60c32dc2e69433e417e8f34234) Committed: https://chromium.googlesource.com/chromium/src/+/901f76da1b2561b550517c69e3a5f6a1278e7e7c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -4 lines) Patch
M components/autofill/core/browser/credit_card.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/autofill/core/browser/credit_card.cc View 1 chunk +9 lines, -3 lines 0 comments Download
M components/autofill/core/browser/credit_card_unittest.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Justin Donnelly
4 years, 9 months ago (2016-03-22 18:02:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
901f76da1b2561b550517c69e3a5f6a1278e7e7c.

Powered by Google App Engine
This is Rietveld 408576698