Don't ever attempt to upload credit cards whose numbers match.

Don't ever attempt to upload credit cards whose numbers match.

Previously, we were using the logic derived from local card handling where if the name or expiration date was different we would offer to save a card even if we already had an autofill entry with that exact card number. But in the case of upload, this will never succeed.

BUG=596515
Committed: https://crrev.com/ee7e2c11cc024f60c32dc2e69433e417e8f34234
Cr-Commit-Position: refs/heads/master@{#381974}

[Justin Donnelly, 2016-03-16 22:26:09]

jdonnelly@chromium.org changed reviewers:
+ mathp@chromium.org

[Justin Donnelly, 2016-03-18 13:53:14]

friendly ping

[Mathieu, 2016-03-18 14:00:24]

On 2016/03/18 at 13:53:14, jdonnelly wrote:
> friendly ping

Sorry I've been travelling this week. It's a nice change, lgtm. 

On a tangent note, we want to improve the local logic and investigate updating
the expiration if the number (and name?) is the same as a locally saved card.
Could potentially do this automatically or reuse some update UI used for
payments cards.

[Justin Donnelly, 2016-03-18 14:10:40]

On 2016/03/18 14:00:24, Mathieu Perreault wrote:
> Sorry I've been travelling this week. It's a nice change, lgtm. 

No problem, thanks.

> On a tangent note, we want to improve the local logic and investigate updating
> the expiration if the number (and name?) is the same as a locally saved card.
> Could potentially do this automatically or reuse some update UI used for
> payments cards.

Yup.

[Justin Donnelly, 2016-03-18 14:10:45]

The CQ bit was checked by jdonnelly@chromium.org

[commit-bot: I haz the power, 2016-03-18 14:10:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1808613004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1808613004/1

[commit-bot: I haz the power, 2016-03-18 15:34:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-18 15:35:16]

Description was changed from

==========
Don't ever attempt to upload credit cards whose numbers match.

Previously, we were using the logic derived from local card handling where if
the name or expiration date was different we would offer to save a card even if
we already had an autofill entry with that exact card number. But in the case of
upload, this will never succeed.

BUG=535784
==========

to

==========
Don't ever attempt to upload credit cards whose numbers match.

Previously, we were using the logic derived from local card handling where if
the name or expiration date was different we would offer to save a card even if
we already had an autofill entry with that exact card number. But in the case of
upload, this will never succeed.

BUG=535784

Committed: https://crrev.com/ee7e2c11cc024f60c32dc2e69433e417e8f34234
Cr-Commit-Position: refs/heads/master@{#381974}
==========

[commit-bot: I haz the power, 2016-03-18 15:35:17]

Patchset 1 (id:??) landed as
https://crrev.com/ee7e2c11cc024f60c32dc2e69433e417e8f34234
Cr-Commit-Position: refs/heads/master@{#381974}

[Justin Donnelly, 2016-03-21 16:46:35]

Description was changed from

==========
Don't ever attempt to upload credit cards whose numbers match.

Previously, we were using the logic derived from local card handling where if
the name or expiration date was different we would offer to save a card even if
we already had an autofill entry with that exact card number. But in the case of
upload, this will never succeed.

BUG=535784

Committed: https://crrev.com/ee7e2c11cc024f60c32dc2e69433e417e8f34234
Cr-Commit-Position: refs/heads/master@{#381974}
==========

to

==========
Don't ever attempt to upload credit cards whose numbers match.

Previously, we were using the logic derived from local card handling where if
the name or expiration date was different we would offer to save a card even if
we already had an autofill entry with that exact card number. But in the case of
upload, this will never succeed.

BUG=596515

Committed: https://crrev.com/ee7e2c11cc024f60c32dc2e69433e417e8f34234
Cr-Commit-Position: refs/heads/master@{#381974}
==========