Introduce PaintWorkletGlobalScope, rename renderWorklet attribute to paintWorklet.

Introduce PaintWorkletGlobalScope, rename renderWorklet attribute to paintWorklet.

Was decided at Sydney F2F to split everything out into it's own worklet at the moment.
This may get revisited at some point in time.
https://drafts.css-houdini.org/css-paint-api/#dom-window-paintworklet

Introduces PaintWorkletGlobalScope with stub function for implementing registerPaint().
https://drafts.css-houdini.org/css-paint-api/#paintworkletglobalscope

BUG=578252
Committed: https://crrev.com/fc7ba0faafadec3816f944d186854b9491dd3098
Cr-Commit-Position: refs/heads/master@{#382744}

[ikilpatrick, 2016-03-22 00:22:51]

ikilpatrick@chromium.org changed reviewers:
+ haraken@chromium.org, kinuko@chromium.org

[ikilpatrick, 2016-03-22 00:22:52]

@kinuko, for worklet changes. This is probably the last patch in the immediate
future you'll have to review. Most other changes now are now going to be at
paint/canvas teams.

@haraken, for bindings changes.

[haraken, 2016-03-22 01:52:56]

LGTM

https://codereview.chromium.org/1818223002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/csspaint/PaintWorklet.h (right):

https://codereview.chromium.org/1818223002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/csspaint/PaintWorklet.h:14:
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(PaintWorklet);

You can remove this since Worklet has WILL_BE_USING_GARBAGE_COLLECTED_MIXIN.

https://codereview.chromium.org/1818223002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.idl (right):

https://codereview.chromium.org/1818223002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.idl:6:
ImplementedAs=DOMWindowPaintWorklet,

How about naming it WindowPaintWorklet? Then you won't need [ImplementedAs].

https://codereview.chromium.org/1818223002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/worklet/Worklet.h (right):

https://codereview.chromium.org/1818223002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/Worklet.h:39: // Worklet inherits the
url and userAgent, from the document.

Unnecessary ','.

[kinuko, 2016-03-22 02:04:02]

lgtm/2

[ikilpatrick, 2016-03-22 20:31:51]

https://codereview.chromium.org/1818223002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/csspaint/PaintWorklet.h (right):

https://codereview.chromium.org/1818223002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/csspaint/PaintWorklet.h:14:
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(PaintWorklet);
On 2016/03/22 01:52:56, haraken wrote:
> 
> You can remove this since Worklet has WILL_BE_USING_GARBAGE_COLLECTED_MIXIN.

Done.

https://codereview.chromium.org/1818223002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.idl (right):

https://codereview.chromium.org/1818223002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.idl:6:
ImplementedAs=DOMWindowPaintWorklet,
On 2016/03/22 01:52:56, haraken wrote:
> 
> How about naming it WindowPaintWorklet? Then you won't need [ImplementedAs].

Done, (previously from cargo-culting other DOMWindow* classes).

https://codereview.chromium.org/1818223002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/worklet/Worklet.h (right):

https://codereview.chromium.org/1818223002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/Worklet.h:39: // Worklet inherits the
url and userAgent, from the document.
On 2016/03/22 01:52:56, haraken wrote:
> 
> Unnecessary ','.

Done.

[ikilpatrick, 2016-03-22 20:31:59]

The CQ bit was checked by ikilpatrick@chromium.org

[ikilpatrick, 2016-03-22 20:32:00]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org,
haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1818223002/#ps100001
(title: "fix interface listing order.")

[commit-bot: I haz the power, 2016-03-22 20:32:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1818223002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1818223002/100001

[commit-bot: I haz the power, 2016-03-23 00:18:23]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-03-23 00:21:31]

Description was changed from

==========
Introduce PaintWorkletGlobalScope, rename renderWorklet attribute to
paintWorklet.

Was decided at Sydney F2F to split everything out into it's own worklet at the
moment.
This may get revisited at some point in time.
https://drafts.css-houdini.org/css-paint-api/#dom-window-paintworklet

Introduces PaintWorkletGlobalScope with stub function for implementing
registerPaint().
https://drafts.css-houdini.org/css-paint-api/#paintworkletglobalscope

BUG=578252
==========

to

==========
Introduce PaintWorkletGlobalScope, rename renderWorklet attribute to
paintWorklet.

Was decided at Sydney F2F to split everything out into it's own worklet at the
moment.
This may get revisited at some point in time.
https://drafts.css-houdini.org/css-paint-api/#dom-window-paintworklet

Introduces PaintWorkletGlobalScope with stub function for implementing
registerPaint().
https://drafts.css-houdini.org/css-paint-api/#paintworkletglobalscope

BUG=578252

Committed: https://crrev.com/fc7ba0faafadec3816f944d186854b9491dd3098
Cr-Commit-Position: refs/heads/master@{#382744}
==========

[commit-bot: I haz the power, 2016-03-23 00:21:32]

Patchset 6 (id:??) landed as
https://crrev.com/fc7ba0faafadec3816f944d186854b9491dd3098
Cr-Commit-Position: refs/heads/master@{#382744}