third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.idl - Issue 1818223002: Introduce PaintWorkletGlobalScope, rename renderWorklet attribute to paintWorklet.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.idl

Issue 1818223002: Introduce PaintWorkletGlobalScope, rename renderWorklet attribute to paintWorklet. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix thing. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/csspaint/PaintWorklet.h ('K') | « third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.idl ('k') | third_party/WebKit/Source/modules/modules.gypi » ('j') | third_party/WebKit/Source/modules/worklet/Worklet.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 [	5 [

6 ImplementedAs=DOMWindowWorklet,	6 ImplementedAs=DOMWindowPaintWorklet,
	haraken 2016/03/22 01:52:56 How about naming it WindowPaintWorklet? Then you w How about naming it WindowPaintWorklet? Then you won't need [ImplementedAs]. ikilpatrick 2016/03/22 20:31:51 Done, (previously from cargo-culting other DOMWind Show quoted text On 2016/03/22 01:52:56, haraken wrote: > > How about naming it WindowPaintWorklet? Then you won't need [ImplementedAs]. Done, (previously from cargo-culting other DOMWindow* classes).
7 RuntimeEnabled=Worklet,	7 RuntimeEnabled=CSSPaintAPI,

8 ] partial interface Window {	8 ] partial interface Window {

9 [CallWith=ExecutionContext] readonly attribute Worklet renderWorklet;	9 [CallWith=ExecutionContext] readonly attribute Worklet paintWorklet;

10 };	10 };

OLD	NEW