Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1818143003: Whitelist some GPU test includes in GN check. (Closed)

Created:
4 years, 9 months ago by brettw
Modified:
4 years, 9 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Whitelist some GPU test includes in GN check. This is a followup to https://codereview.chromium.org/1800343002/ that broke the GPU FYI bots that use internal_gles2_conform_tests = true CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel TBR=piman Committed: https://crrev.com/1d072e9867ff0fc84464d2cb55e32408d61144d4 Cr-Commit-Position: refs/heads/master@{#382402}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M gpu/gles2_conform_support/native/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/gles2_conform_support/native/egl_native.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/gles2_conform_support/native/egl_native_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/gles2_conform_support/native/egl_native_windowless.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/gles2_conform_support/native/egl_native_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/gles2_conform_support/native/main.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1818143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1818143003/1
4 years, 9 months ago (2016-03-21 21:04:31 UTC) #5
brettw
4 years, 9 months ago (2016-03-21 21:31:04 UTC) #6
piman
lgtm
4 years, 9 months ago (2016-03-21 21:43:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 21:53:50 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1d072e9867ff0fc84464d2cb55e32408d61144d4 Cr-Commit-Position: refs/heads/master@{#382402}
4 years, 9 months ago (2016-03-21 21:55:29 UTC) #11
oetuaho-nv
4 years, 9 months ago (2016-03-22 09:52:10 UTC) #12
Message was sent while issue was closed.
Thanks for the quick fix!

Powered by Google App Engine
This is Rietveld 408576698