Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 1818133002: Move TestSafeBrowsingService* to anonymous namespace (Closed)

Created:
4 years, 9 months ago by Jialiu Lin
Modified:
4 years, 9 months ago
Reviewers:
Nico
CC:
asanka, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move TestSafeBrowsingService* to anonymous namespace BUG=596628 Committed: https://crrev.com/bd3dbdb8139de35b3e38deb20a3e83406d5b8814 Cr-Commit-Position: refs/heads/master@{#382381}

Patch Set 1 #

Total comments: 1

Patch Set 2 : indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/download/download_browsertest.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Jialiu Lin
Hi thakis@, This CL addresses your comment in https://crrev.com/1784433003 And with regard to your "8th ...
4 years, 9 months ago (2016-03-21 19:47:04 UTC) #2
Nico
https://codereview.chromium.org/1818133002/diff/1/chrome/browser/download/download_browsertest.cc File chrome/browser/download/download_browsertest.cc (right): https://codereview.chromium.org/1818133002/diff/1/chrome/browser/download/download_browsertest.cc#newcode1082 chrome/browser/download/download_browsertest.cc:1082: class FakeDownloadProtectionService don't intend inside of namespaces. (in general, ...
4 years, 9 months ago (2016-03-21 19:51:01 UTC) #3
Jialiu Lin
Thanks, thakis@. Indentation fixed.
4 years, 9 months ago (2016-03-21 20:00:00 UTC) #6
Nico
lgtm, thanks!
4 years, 9 months ago (2016-03-21 20:01:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1818133002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1818133002/60001
4 years, 9 months ago (2016-03-21 20:07:52 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 9 months ago (2016-03-21 20:47:45 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 20:48:59 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bd3dbdb8139de35b3e38deb20a3e83406d5b8814
Cr-Commit-Position: refs/heads/master@{#382381}

Powered by Google App Engine
This is Rietveld 408576698