Move TestSafeBrowsingService* to anonymous namespace

chrome/browser/download/download_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/download_browsertest.h"
 
 #include <stdint.h>
 #include <sstream>
 #include <utility>
 
@@ skipping 1059 matching lines @@
 
   // Location of the test data.
   base::FilePath test_dir_;
 
   // Location of the downloads directory for these tests
   base::ScopedTempDir downloads_directory_;
 
   scoped_ptr<DownloadTestFileActivityObserver> file_activity_observer_;
 };
 
-class FakeDownloadProtectionService
-    : public safe_browsing::DownloadProtectionService {
- public:
-  FakeDownloadProtectionService()
-      : safe_browsing::DownloadProtectionService(nullptr, nullptr) {}
+namespace {
 
-  void CheckClientDownload(DownloadItem* download_item,
-      const CheckDownloadCallback& callback) override {
-    callback.Run(
-      safe_browsing::DownloadProtectionService::UNCOMMON);
-  }
-};
+  class FakeDownloadProtectionService

[Nico, 2016/03/21 19:51:01]

don't intend inside of namespaces.

(in general, run `git cl format` after committing all your changes to a branch
to have all code you changed formatted correctly automatically -- just run `git
commit -am.` after running `git cl format`, or run `git diff` to see what it
did)

+      : public safe_browsing::DownloadProtectionService {
+   public:
+    FakeDownloadProtectionService()
+        : safe_browsing::DownloadProtectionService(nullptr, nullptr) {}
 
-class FakeSafeBrowsingService : public safe_browsing::SafeBrowsingService {
- public:
-  FakeSafeBrowsingService() {}
+    void CheckClientDownload(DownloadItem* download_item,
+        const CheckDownloadCallback& callback) override {
+      callback.Run(
+        safe_browsing::DownloadProtectionService::UNCOMMON);
+    }
+  };
 
-  safe_browsing::DownloadProtectionService* CreateDownloadProtectionService(
-      net::URLRequestContextGetter* not_used_request_context_getter) override {
-    return new FakeDownloadProtectionService();
-  }
+  class FakeSafeBrowsingService : public safe_browsing::SafeBrowsingService {
+   public:
+    FakeSafeBrowsingService() {}
 
-  std::string GetDownloadReport() const { return report_; }
+    safe_browsing::DownloadProtectionService* CreateDownloadProtectionService(
+        net::URLRequestContextGetter* unused_request_context_getter) override {
+      return new FakeDownloadProtectionService();
+    }
 
- protected:
-  ~FakeSafeBrowsingService() override {}
+    std::string GetDownloadReport() const { return report_; }
 
-  void SendSerializedDownloadReport(const std::string& report) override {
-    report_ = report;
-  }
+   protected:
+    ~FakeSafeBrowsingService() override {}
 
-  std::string report_;
-};
+    void SendSerializedDownloadReport(const std::string& report) override {
+      report_ = report;
+    }
 
-// Factory that creates FakeSafeBrowsingService instances.
-class TestSafeBrowsingServiceFactory
-    : public safe_browsing::SafeBrowsingServiceFactory {
- public:
-  TestSafeBrowsingServiceFactory() : fake_safe_browsing_service_(nullptr) {}
-  ~TestSafeBrowsingServiceFactory() override {}
+    std::string report_;
+  };
 
-  safe_browsing::SafeBrowsingService* CreateSafeBrowsingService() override {
-    DCHECK(!fake_safe_browsing_service_);
-    fake_safe_browsing_service_ = new FakeSafeBrowsingService();
-    return fake_safe_browsing_service_.get();
-  }
+  // Factory that creates FakeSafeBrowsingService instances.
+  class TestSafeBrowsingServiceFactory
+      : public safe_browsing::SafeBrowsingServiceFactory {
+   public:
+    TestSafeBrowsingServiceFactory() : fake_safe_browsing_service_(nullptr) {}
+    ~TestSafeBrowsingServiceFactory() override {}
 
-  scoped_refptr<FakeSafeBrowsingService> fake_safe_browsing_service() {
-    return fake_safe_browsing_service_;
-  }
+    safe_browsing::SafeBrowsingService* CreateSafeBrowsingService() override {
+      DCHECK(!fake_safe_browsing_service_);
+      fake_safe_browsing_service_ = new FakeSafeBrowsingService();
+      return fake_safe_browsing_service_.get();
+    }
 
- private:
-  scoped_refptr<FakeSafeBrowsingService> fake_safe_browsing_service_;
-};
+    scoped_refptr<FakeSafeBrowsingService> fake_safe_browsing_service() {
+      return fake_safe_browsing_service_;
+    }
 
-class DownloadTestWithFakeSafeBrowsing : public DownloadTest {
- public:
-  DownloadTestWithFakeSafeBrowsing()
-      : test_safe_browsing_factory_(new TestSafeBrowsingServiceFactory()) {}
+   private:
+    scoped_refptr<FakeSafeBrowsingService> fake_safe_browsing_service_;
+  };
 
-  void SetUp() override {
-    safe_browsing::SafeBrowsingService::RegisterFactory(
-        test_safe_browsing_factory_.get());
-    DownloadTest::SetUp();
-  }
+  class DownloadTestWithFakeSafeBrowsing : public DownloadTest {
+   public:
+    DownloadTestWithFakeSafeBrowsing()
+        : test_safe_browsing_factory_(new TestSafeBrowsingServiceFactory()) {}
 
-  void TearDown() override {
-    safe_browsing::SafeBrowsingService::RegisterFactory(nullptr);
-    DownloadTest::TearDown();
-  }
+    void SetUp() override {
+      safe_browsing::SafeBrowsingService::RegisterFactory(
+          test_safe_browsing_factory_.get());
+      DownloadTest::SetUp();
+    }
 
- protected:
-  scoped_ptr<TestSafeBrowsingServiceFactory> test_safe_browsing_factory_;
-};
+    void TearDown() override {
+      safe_browsing::SafeBrowsingService::RegisterFactory(nullptr);
+      DownloadTest::TearDown();
+    }
+
+   protected:
+    scoped_ptr<TestSafeBrowsingServiceFactory> test_safe_browsing_factory_;
+  };
+
+}  // namespace
 
 // NOTES:
 //
 // Files for these tests are found in DIR_TEST_DATA (currently
 // "chrome\test\data\", see chrome_paths.cc).
 // Mock responses have extension .mock-http-headers appended to the file name.
 
 // Download a file due to the associated MIME type.
 IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadMimeType) {
   GURL url(URLRequestMockHTTPJob::GetMockUrl(kDownloadTest1Path));
@@ skipping 2499 matching lines @@
 
   scoped_ptr<content::DownloadTestObserver> observer(DangerousDownloadWaiter(
       browser(), 1, content::DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_DENY));
   ui_test_utils::NavigateToURL(browser(), extension_url);
 
   observer->WaitForFinished();
 
   // Download shelf should close.
   EXPECT_FALSE(browser()->window()->IsDownloadShelfVisible());
 }