tests/PictureTest.cpp - Issue 1818043002: SkTypeface::MakeFromName to take SkFontStyle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/PictureTest.cpp

Issue 1818043002: SkTypeface::MakeFromName to take SkFontStyle. (Closed) Base URL: https://chromium.googlesource.com/skia.git@master

Patch Set: Android fix + nit fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/PictureTest.cpp

diff --git a/tests/PictureTest.cpp b/tests/PictureTest.cpp

index c71e66309aa71cde7b567276950fdf306c582fba..3dcdcfcf2713f592f831a03d004ae4a2bc748238 100644

--- a/tests/PictureTest.cpp

+++ b/tests/PictureTest.cpp

@@ -1116,7 +1116,8 @@ static void test_typeface(skiatest::Reporter* reporter) {

SkPictureRecorder recorder;

SkCanvas* canvas = recorder.beginRecording(10, 10);

SkPaint paint;

- paint.setTypeface(SkTypeface::MakeFromName("Arial", SkTypeface::kItalic));

+ paint.setTypeface(SkTypeface::MakeFromName("Arial",

+ SkFontStyle::FromOldStyle(SkTypeface::kItalic)));

canvas->drawText("Q", 1, 0, 10, paint);

sk_sp<SkPicture> picture(recorder.finishRecordingAsPicture());

SkDynamicMemoryWStream stream;

« no previous file with comments | « tests/PDFPrimitivesTest.cpp ('k') | tests/TypefaceTest.cpp » ('j') | no next file with comments »