tests/PDFPrimitivesTest.cpp - Issue 1818043002: SkTypeface::MakeFromName to take SkFontStyle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/PDFPrimitivesTest.cpp

Issue 1818043002: SkTypeface::MakeFromName to take SkFontStyle. (Closed) Base URL: https://chromium.googlesource.com/skia.git@master

Patch Set: Android fix + nit fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/PDFPrimitivesTest.cpp

diff --git a/tests/PDFPrimitivesTest.cpp b/tests/PDFPrimitivesTest.cpp

index 07ddabc9126d18f2a0df71888b251cc477b2ad80..e438bfef78aa98d670a4a1a68627ecb549702a69 100644

--- a/tests/PDFPrimitivesTest.cpp

+++ b/tests/PDFPrimitivesTest.cpp

@@ -436,7 +436,7 @@ DEF_TEST(PDFFontCanEmbedTypeface, reporter) {

!SkPDFFont::CanEmbedTypeface(noEmbedTypeface.get(), &canon));

}

sk_sp<SkTypeface> portableTypeface(

- sk_tool_utils::create_portable_typeface(NULL, SkTypeface::kNormal));

+ sk_tool_utils::create_portable_typeface(NULL, SkFontStyle()));

REPORTER_ASSERT(reporter,

SkPDFFont::CanEmbedTypeface(portableTypeface.get(), &canon));

}

« no previous file with comments | « tests/FontObjTest.cpp ('k') | tests/PictureTest.cpp » ('j') | no next file with comments »