Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1818003002: [crankshaft] Check if the function is callable before generating a tail call via Call builtin. (Closed)

Created:
4 years, 9 months ago by Igor Sheludko
Modified:
4 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@tco-crank-4
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Check if the function is callable before generating a tail call via Call builtin. This is necessary to ensure that "Called non callable" exception will get a proper message and stack trace even for calls at tail position. BUG=chromium:595615, v8:4698 LOG=N Committed: https://crrev.com/e6dca379b633682e64542c86ed68941ccca221f0 Cr-Commit-Position: refs/heads/master@{#34962}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -11 lines) Patch
M src/crankshaft/hydrogen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 3 chunks +34 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-595615.js View 1 chunk +7 lines, -10 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1818003002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1818003002/40001
4 years, 9 months ago (2016-03-21 11:53:58 UTC) #5
Igor Sheludko
PTAL
4 years, 9 months ago (2016-03-21 12:20:55 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-21 14:03:13 UTC) #9
Benedikt Meurer
lgtm
4 years, 9 months ago (2016-03-21 18:00:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1818003002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1818003002/40001
4 years, 9 months ago (2016-03-21 18:54:58 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 9 months ago (2016-03-21 19:22:49 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 19:24:36 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6dca379b633682e64542c86ed68941ccca221f0
Cr-Commit-Position: refs/heads/master@{#34962}

Powered by Google App Engine
This is Rietveld 408576698