[crankshaft] Fixing ES6 tail call elimination.

[crankshaft] Fixing ES6 tail call elimination.

In case when F inlined normal call to G which tail calls H we should not write translation for G for the tail call site.
Otherwise we will see G in a stack trace inside H.

This CL also enables all existing tests related to ES6 tail call elimination and adds more combinations.

TBR=bmeurer@chromium.org
BUG=v8:4698
LOG=N

Committed: https://crrev.com/689980f7d4dfd4c29492f616d7b616b86ec9af91
Cr-Commit-Position: refs/heads/master@{#34830}

Committed: https://crrev.com/acbb968dedd2b02b5447215a579cf4cdc99bc69a
Cr-Commit-Position: refs/heads/master@{#34920}

[Igor Sheludko, 2016-03-10 17:10:40]

Description was changed from

==========
[crankshaft] Fixing ES6 tail call elimination.

In case when F inlined normal call to G which tail calls H we should not write
translation for G for the tail call site.
Otherwise we will see G in a stack trace inside H.

This CL also enables all existing tests related to ES6 tail call elimination.

BUG=v8:4698
LOG=N
==========

to

==========
[crankshaft] Fixing ES6 tail call elimination.

In case when F inlined normal call to G which tail calls H we should not write
translation for G for the tail call site.
Otherwise we will see G in a stack trace inside H.

This CL also enables all existing tests related to ES6 tail call elimination.

BUG=v8:4698
LOG=N
==========

[Igor Sheludko, 2016-03-11 13:33:39]

Patchset #2 (id:20001) has been deleted

[Igor Sheludko, 2016-03-11 13:49:04]

Patchset #3 (id:60001) has been deleted

[Igor Sheludko, 2016-03-11 13:51:06]

Patchset #2 (id:40001) has been deleted

[Igor Sheludko, 2016-03-11 13:51:13]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-11 13:51:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780043004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780043004/80001

[Igor Sheludko, 2016-03-11 13:51:36]

ishell@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Igor Sheludko, 2016-03-11 13:51:36]

PTAL

[commit-bot: I haz the power, 2016-03-11 14:06:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 14:06:20]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...)

[Igor Sheludko, 2016-03-11 14:20:35]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-11 14:20:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780043004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780043004/100001

[commit-bot: I haz the power, 2016-03-11 14:22:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 14:22:21]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...)
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/15216)
  v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/2810)
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/12278)

[Igor Sheludko, 2016-03-11 14:26:58]

Patchset #3 (id:100001) has been deleted

[Igor Sheludko, 2016-03-11 14:27:22]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-11 14:27:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780043004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780043004/120001

[commit-bot: I haz the power, 2016-03-11 15:09:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 15:09:09]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-03-14 08:10:36]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-14 08:10:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780043004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780043004/140001

[commit-bot: I haz the power, 2016-03-14 08:36:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-14 08:36:40]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-03-16 15:18:27]

LGTM.

https://codereview.chromium.org/1780043004/diff/140001/test/mjsunit/mjsunit.s...
File test/mjsunit/mjsunit.status (right):

https://codereview.chromium.org/1780043004/diff/140001/test/mjsunit/mjsunit.s...
test/mjsunit/mjsunit.status:817: 'es6/tail-call': [SKIP],
Mythri's CL fixing this issue is on the brink of landing. Depending on whether
it makes it into the tree first or not, can we remove this "skip"?

See: https://codereview.chromium.org/1796893002/

[Igor Sheludko, 2016-03-16 15:25:37]

Thanks!

https://codereview.chromium.org/1780043004/diff/140001/test/mjsunit/mjsunit.s...
File test/mjsunit/mjsunit.status (right):

https://codereview.chromium.org/1780043004/diff/140001/test/mjsunit/mjsunit.s...
test/mjsunit/mjsunit.status:817: 'es6/tail-call': [SKIP],
On 2016/03/16 15:18:27, Michael Starzinger wrote:
> Mythri's CL fixing this issue is on the brink of landing. Depending on whether
> it makes it into the tree first or not, can we remove this "skip"?
> 
> See: https://codereview.chromium.org/1796893002/

Done.

[Igor Sheludko, 2016-03-16 15:25:48]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-16 15:25:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780043004/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780043004/160001

[Igor Sheludko, 2016-03-16 15:26:31]

The CQ bit was unchecked by ishell@chromium.org

[Igor Sheludko, 2016-03-16 16:02:37]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-16 16:02:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780043004/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780043004/180001

[Igor Sheludko, 2016-03-16 16:03:00]

Description was changed from

==========
[crankshaft] Fixing ES6 tail call elimination.

In case when F inlined normal call to G which tail calls H we should not write
translation for G for the tail call site.
Otherwise we will see G in a stack trace inside H.

This CL also enables all existing tests related to ES6 tail call elimination.

BUG=v8:4698
LOG=N
==========

to

==========
[crankshaft] Fixing ES6 tail call elimination.

In case when F inlined normal call to G which tail calls H we should not write
translation for G for the tail call site.
Otherwise we will see G in a stack trace inside H.

This CL also enables all existing tests related to ES6 tail call elimination.

TBR=bmeurer@chromium.org
BUG=v8:4698
LOG=N
==========

[commit-bot: I haz the power, 2016-03-16 16:04:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 16:04:53]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)
  v8_linux_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/3037)
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/17150)

[Igor Sheludko, 2016-03-16 16:10:12]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-16 16:10:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780043004/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780043004/200001

[commit-bot: I haz the power, 2016-03-16 16:36:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 16:36:46]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-03-16 17:03:07]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-03-16 17:03:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1780043004/#ps200001
(title: "Rebasing again")

[commit-bot: I haz the power, 2016-03-16 17:03:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780043004/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780043004/200001

[commit-bot: I haz the power, 2016-03-16 17:05:22]

Description was changed from

==========
[crankshaft] Fixing ES6 tail call elimination.

In case when F inlined normal call to G which tail calls H we should not write
translation for G for the tail call site.
Otherwise we will see G in a stack trace inside H.

This CL also enables all existing tests related to ES6 tail call elimination.

TBR=bmeurer@chromium.org
BUG=v8:4698
LOG=N
==========

to

==========
[crankshaft] Fixing ES6 tail call elimination.

In case when F inlined normal call to G which tail calls H we should not write
translation for G for the tail call site.
Otherwise we will see G in a stack trace inside H.

This CL also enables all existing tests related to ES6 tail call elimination.

TBR=bmeurer@chromium.org
BUG=v8:4698
LOG=N
==========

[commit-bot: I haz the power, 2016-03-16 17:05:24]

Committed patchset #7 (id:200001)

[commit-bot: I haz the power, 2016-03-16 17:06:51]

Description was changed from

==========
[crankshaft] Fixing ES6 tail call elimination.

In case when F inlined normal call to G which tail calls H we should not write
translation for G for the tail call site.
Otherwise we will see G in a stack trace inside H.

This CL also enables all existing tests related to ES6 tail call elimination.

TBR=bmeurer@chromium.org
BUG=v8:4698
LOG=N
==========

to

==========
[crankshaft] Fixing ES6 tail call elimination.

In case when F inlined normal call to G which tail calls H we should not write
translation for G for the tail call site.
Otherwise we will see G in a stack trace inside H.

This CL also enables all existing tests related to ES6 tail call elimination.

TBR=bmeurer@chromium.org
BUG=v8:4698
LOG=N

Committed: https://crrev.com/689980f7d4dfd4c29492f616d7b616b86ec9af91
Cr-Commit-Position: refs/heads/master@{#34830}
==========

[commit-bot: I haz the power, 2016-03-16 17:06:53]

Patchset 7 (id:??) landed as
https://crrev.com/689980f7d4dfd4c29492f616d7b616b86ec9af91
Cr-Commit-Position: refs/heads/master@{#34830}

[Michael Achenbach, 2016-03-16 18:11:58]

A revert of this CL (patchset #7 id:200001) has been created in
https://codereview.chromium.org/1814433002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Leads to mac gc stress crashes:
https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds....

[Benedikt Meurer, 2016-03-21 07:48:03]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2016-03-21 07:48:04]

LGTM on patchset 8.

[Igor Sheludko, 2016-03-21 07:48:59]

Fixing GC stress issue (lazy deopt case).

https://codereview.chromium.org/1780043004/diff/220001/src/crankshaft/ia32/li...
File src/crankshaft/ia32/lithium-ia32.cc (right):

https://codereview.chromium.org/1780043004/diff/220001/src/crankshaft/ia32/li...
src/crankshaft/ia32/lithium-ia32.cc:935: // therefore this lazy bailout can be
skipped.
Currently this is not true, because we throw from the Call builtin but I'll fix
this in a separate CL.

[Igor Sheludko, 2016-03-21 08:15:45]

Description was changed from

==========
[crankshaft] Fixing ES6 tail call elimination.

In case when F inlined normal call to G which tail calls H we should not write
translation for G for the tail call site.
Otherwise we will see G in a stack trace inside H.

This CL also enables all existing tests related to ES6 tail call elimination.

TBR=bmeurer@chromium.org
BUG=v8:4698
LOG=N

Committed: https://crrev.com/689980f7d4dfd4c29492f616d7b616b86ec9af91
Cr-Commit-Position: refs/heads/master@{#34830}
==========

to

==========
[crankshaft] Fixing ES6 tail call elimination.

In case when F inlined normal call to G which tail calls H we should not write
translation for G for the tail call site.
Otherwise we will see G in a stack trace inside H.

This CL also enables all existing tests related to ES6 tail call elimination.

TBR=bmeurer@chromium.org
BUG=v8:4698
LOG=N

Committed: https://crrev.com/689980f7d4dfd4c29492f616d7b616b86ec9af91
Cr-Commit-Position: refs/heads/master@{#34830}
==========

[Igor Sheludko, 2016-03-21 08:16:16]

Description was changed from

==========
[crankshaft] Fixing ES6 tail call elimination.

In case when F inlined normal call to G which tail calls H we should not write
translation for G for the tail call site.
Otherwise we will see G in a stack trace inside H.

This CL also enables all existing tests related to ES6 tail call elimination.

TBR=bmeurer@chromium.org
BUG=v8:4698
LOG=N

Committed: https://crrev.com/689980f7d4dfd4c29492f616d7b616b86ec9af91
Cr-Commit-Position: refs/heads/master@{#34830}
==========

to

==========
[crankshaft] Fixing ES6 tail call elimination.

In case when F inlined normal call to G which tail calls H we should not write
translation for G for the tail call site.
Otherwise we will see G in a stack trace inside H.

This CL also enables all existing tests related to ES6 tail call elimination and
adds more combinations.

TBR=bmeurer@chromium.org
BUG=v8:4698
LOG=N

Committed: https://crrev.com/689980f7d4dfd4c29492f616d7b616b86ec9af91
Cr-Commit-Position: refs/heads/master@{#34830}
==========

[Igor Sheludko, 2016-03-21 08:16:55]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-21 08:17:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780043004/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780043004/240001

[commit-bot: I haz the power, 2016-03-21 08:45:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-21 08:45:39]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-03-21 08:46:09]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-03-21 08:46:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1780043004/#ps240001
(title: "Rebasing")

[commit-bot: I haz the power, 2016-03-21 08:46:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780043004/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780043004/240001

[commit-bot: I haz the power, 2016-03-21 08:48:22]

Description was changed from

==========
[crankshaft] Fixing ES6 tail call elimination.

In case when F inlined normal call to G which tail calls H we should not write
translation for G for the tail call site.
Otherwise we will see G in a stack trace inside H.

This CL also enables all existing tests related to ES6 tail call elimination and
adds more combinations.

TBR=bmeurer@chromium.org
BUG=v8:4698
LOG=N

Committed: https://crrev.com/689980f7d4dfd4c29492f616d7b616b86ec9af91
Cr-Commit-Position: refs/heads/master@{#34830}
==========

to

==========
[crankshaft] Fixing ES6 tail call elimination.

In case when F inlined normal call to G which tail calls H we should not write
translation for G for the tail call site.
Otherwise we will see G in a stack trace inside H.

This CL also enables all existing tests related to ES6 tail call elimination and
adds more combinations.

TBR=bmeurer@chromium.org
BUG=v8:4698
LOG=N

Committed: https://crrev.com/689980f7d4dfd4c29492f616d7b616b86ec9af91
Cr-Commit-Position: refs/heads/master@{#34830}
==========

[commit-bot: I haz the power, 2016-03-21 08:48:23]

Committed patchset #9 (id:240001)

[commit-bot: I haz the power, 2016-03-21 08:48:43]

Description was changed from

==========
[crankshaft] Fixing ES6 tail call elimination.

In case when F inlined normal call to G which tail calls H we should not write
translation for G for the tail call site.
Otherwise we will see G in a stack trace inside H.

This CL also enables all existing tests related to ES6 tail call elimination and
adds more combinations.

TBR=bmeurer@chromium.org
BUG=v8:4698
LOG=N

Committed: https://crrev.com/689980f7d4dfd4c29492f616d7b616b86ec9af91
Cr-Commit-Position: refs/heads/master@{#34830}
==========

to

==========
[crankshaft] Fixing ES6 tail call elimination.

In case when F inlined normal call to G which tail calls H we should not write
translation for G for the tail call site.
Otherwise we will see G in a stack trace inside H.

This CL also enables all existing tests related to ES6 tail call elimination and
adds more combinations.

TBR=bmeurer@chromium.org
BUG=v8:4698
LOG=N

Committed: https://crrev.com/689980f7d4dfd4c29492f616d7b616b86ec9af91
Cr-Commit-Position: refs/heads/master@{#34830}

Committed: https://crrev.com/acbb968dedd2b02b5447215a579cf4cdc99bc69a
Cr-Commit-Position: refs/heads/master@{#34920}
==========

[commit-bot: I haz the power, 2016-03-21 08:48:45]

Patchset 9 (id:??) landed as
https://crrev.com/acbb968dedd2b02b5447215a579cf4cdc99bc69a
Cr-Commit-Position: refs/heads/master@{#34920}