Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1817943003: Constraints: Make advanced list be a list. (Closed)

Created:
4 years, 9 months ago by hta - Chromium
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Constraints: Make advanced list be a list. Previous behavior: A list of optional constraints resulted in a single advanced element, with one field for each value. New behavior: A list of optional constraints results in a list of advanced elements, with one field set for each value. The difference is important when there are mulitple values with the same name. For constraints with distinct names, there should be no difference. BUG=594929 Review URL: https://codereview.chromium.org/1808173002 Cr-Commit-Position: refs/heads/master@{#381724} (cherry picked from commit 20078f72c457d9612c1e12044e7e87fc721b4397) Conflicts: third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp Committed: https://chromium.googlesource.com/chromium/src/+/557071c271897464f0c1eceb1e8a6590ffb13916

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
hta - Chromium
4 years, 9 months ago (2016-03-21 08:08:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
557071c271897464f0c1eceb1e8a6590ffb13916.

Powered by Google App Engine
This is Rietveld 408576698