Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1808173002: Constraints: Make advanced list be a list. (Closed)

Created:
4 years, 9 months ago by hta - Chromium
Modified:
4 years, 9 months ago
CC:
chromium-reviews, blink-reviews, tommyw+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Constraints: Make advanced list be a list. Previous behavior: A list of optional constraints resulted in a single advanced element, with one field for each value. New behavior: A list of optional constraints results in a list of advanced elements, with one field set for each value. The difference is important when there are mulitple values with the same name. For constraints with distinct names, there should be no difference. BUG=594929 Committed: https://crrev.com/20078f72c457d9612c1e12044e7e87fc721b4397 Cr-Commit-Position: refs/heads/master@{#381724}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp View 1 chunk +9 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808173002/1
4 years, 9 months ago (2016-03-17 10:40:45 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-17 11:48:02 UTC) #5
hta - Chromium
I started this to get a better view of what was being passed in, but ...
4 years, 9 months ago (2016-03-17 13:54:44 UTC) #7
tommi (sloooow) - chröme
lgtm
4 years, 9 months ago (2016-03-17 15:01:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808173002/1
4 years, 9 months ago (2016-03-17 16:08:13 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 16:13:17 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 16:14:56 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20078f72c457d9612c1e12044e7e87fc721b4397
Cr-Commit-Position: refs/heads/master@{#381724}

Powered by Google App Engine
This is Rietveld 408576698