Dismiss action in tab modal dialogs.

chrome/browser/chromeos/power/idle_action_warning_dialog_view.h

Index: chrome/browser/chromeos/power/idle_action_warning_dialog_view.h
diff --git a/chrome/browser/chromeos/power/idle_action_warning_dialog_view.h b/chrome/browser/chromeos/power/idle_action_warning_dialog_view.h
index c45b2ff62e5cf0d2bccfa7a6edb52998bf8a64a7..92dc34ee8770c7dfbcaab3815cd3dc5e7ab65b40 100644
--- a/chrome/browser/chromeos/power/idle_action_warning_dialog_view.h
+++ b/chrome/browser/chromeos/power/idle_action_warning_dialog_view.h
@@ -17,7 +17,7 @@ namespace chromeos {
 class IdleActionWarningDialogView : public views::DialogDelegateView {
  public:
   IdleActionWarningDialogView();
-  void Close();
+  void CloseDialog();

[achuithb, 2013/07/29 17:56:38]

Why does this need to be renamed?

[fdoray, 2013/07/29 18:38:38]

There's a new DialogDelegate::Close method which name is conflicting with this
method (DialogDelegate is a base class for this class).

DialogDelegate::Close is called when the dialog is closed without selecting an
option (pressing X button, close Chrome, window manager gesture...). Unlike
IdleActionWarningDialogView::Close, it doesn't actually close the dialog. We
cannot override DialogDelegate::Close here because the 2 methods don't do the
same thing at all.

DialogDelegate::Close is the name suggested by Ben.

On 2013/07/29 17:56:38, achuith.bhandarkar wrote:

 
   // views::DialogDelegateView:
   virtual ui::ModalType GetModalType() const OVERRIDE;