Dismiss action in tab modal dialogs.

chrome/browser/chromeos/power/idle_action_warning_dialog_view.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_POWER_IDLE_ACTION_WARNING_DIALOG_VIEW_H_
 #define CHROME_BROWSER_CHROMEOS_POWER_IDLE_ACTION_WARNING_DIALOG_VIEW_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "ui/views/window/dialog_delegate.h"
 
 namespace chromeos {
 
 // Shows a modal warning dialog that the idle action is imminent. Since the
 // warning is only really necessary when the idle action is to log out the user,
 // the warning is hard-coded to warn about logout.
 class IdleActionWarningDialogView : public views::DialogDelegateView {
  public:
   IdleActionWarningDialogView();
-  void Close();
+  void CloseDialog();

[achuithb, 2013/07/29 17:56:38]

Why does this need to be renamed?

[fdoray, 2013/07/29 18:38:38]

There's a new DialogDelegate::Close method which name is conflicting with this
method (DialogDelegate is a base class for this class).

DialogDelegate::Close is called when the dialog is closed without selecting an
option (pressing X button, close Chrome, window manager gesture...). Unlike
IdleActionWarningDialogView::Close, it doesn't actually close the dialog. We
cannot override DialogDelegate::Close here because the 2 methods don't do the
same thing at all.

DialogDelegate::Close is the name suggested by Ben.

On 2013/07/29 17:56:38, achuith.bhandarkar wrote:

 
   // views::DialogDelegateView:
   virtual ui::ModalType GetModalType() const OVERRIDE;
   virtual string16 GetWindowTitle() const OVERRIDE;
   virtual int GetDialogButtons() const OVERRIDE;
   virtual bool Cancel() OVERRIDE;
 
  private:
   virtual ~IdleActionWarningDialogView();
 
   bool closing_;
 
   DISALLOW_COPY_AND_ASSIGN(IdleActionWarningDialogView);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_POWER_IDLE_ACTION_WARNING_DIALOG_VIEW_H_