Handle iOS gtest app bundles in copy_asan_runtime_dylib.sh

Handle iOS gtest app bundles in copy_asan_runtime_dylib.sh

Unlike Chromium.app, gtest binaries contain the executable right on the first level
(e.g. base_unittests.app/base_unittests), so the ASan runtime can be put right into the bundle.

R=stuartmorgan@chromium.org, thakis@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209647

[Alexander Potapenko, 2013-06-28 16:34:43]

Please take a look

[Nico, 2013-06-28 19:11:39]

(+stuart to check my ios half-knowledge)

https://codereview.chromium.org/18177011/diff/1/build/mac/copy_asan_runtime_d...
File build/mac/copy_asan_runtime_dylib.sh (right):

https://codereview.chromium.org/18177011/diff/1/build/mac/copy_asan_runtime_d...
build/mac/copy_asan_runtime_dylib.sh:41: BINARY_DIR_EXT=$(echo "${BINARY_DIR}" |
sed 's/^.*\.//')
I don't think that's the right check. From what I understand, Mac app bundles
contain a "Contents" folder with the contents of the bundle (and nothing else)
and iOS bundles have all files right in the bundle. So I'd check for a Contents
subfolder instead to differentiate mac and ios bundles.

[Alexander Potapenko, 2013-07-01 08:35:01]

https://codereview.chromium.org/18177011/diff/1/build/mac/copy_asan_runtime_d...
File build/mac/copy_asan_runtime_dylib.sh (right):

https://codereview.chromium.org/18177011/diff/1/build/mac/copy_asan_runtime_d...
build/mac/copy_asan_runtime_dylib.sh:41: BINARY_DIR_EXT=$(echo "${BINARY_DIR}" |
sed 's/^.*\.//')
On 2013/06/28 19:11:40, Nico wrote:
> I don't think that's the right check. From what I understand, Mac app bundles
> contain a "Contents" folder with the contents of the bundle (and nothing else)
> and iOS bundles have all files right in the bundle. So I'd check for a
Contents
> subfolder instead to differentiate mac and ios bundles.
The binary resides in Contents/MacOS, how about checking for "MacOS" (see the
new patchset)?
We can also simply put the runtime library next to the executable (i.e. into
appname.app/Contents/MacOS for rich apps and testname.app/ for tests)

[stuartmorgan, 2013-07-01 09:09:12]

Looking for MacOS LGTM.

(Please fix the CL description to have a blank line after the first line so it's
not all run together in git logs)

https://codereview.chromium.org/18177011/diff/5001/build/mac/copy_asan_runtim...
File build/mac/copy_asan_runtime_dylib.sh (right):

https://codereview.chromium.org/18177011/diff/5001/build/mac/copy_asan_runtim...
build/mac/copy_asan_runtime_dylib.sh:38: # Check whether the directory
containing the executable binary has an .app
Update comment to reflect code.

https://codereview.chromium.org/18177011/diff/5001/build/mac/copy_asan_runtim...
build/mac/copy_asan_runtime_dylib.sh:41: BINARY_DIR_EXT=$(echo "${BINARY_DIR}" |
sed 's/^.*\.//')
Unused now.

[Alexander Potapenko, 2013-07-01 09:52:43]

On 2013/07/01 09:09:12, stuartmorgan wrote:
> Looking for MacOS LGTM.
> 
> (Please fix the CL description to have a blank line after the first line so
it's
> not all run together in git logs)
Done

[Alexander Potapenko, 2013-07-01 09:52:52]

https://codereview.chromium.org/18177011/diff/5001/build/mac/copy_asan_runtim...
File build/mac/copy_asan_runtime_dylib.sh (right):

https://codereview.chromium.org/18177011/diff/5001/build/mac/copy_asan_runtim...
build/mac/copy_asan_runtime_dylib.sh:38: # Check whether the directory
containing the executable binary has an .app
On 2013/07/01 09:09:12, stuartmorgan wrote:
> Update comment to reflect code.

Done.

https://codereview.chromium.org/18177011/diff/5001/build/mac/copy_asan_runtim...
build/mac/copy_asan_runtime_dylib.sh:41: BINARY_DIR_EXT=$(echo "${BINARY_DIR}" |
sed 's/^.*\.//')
On 2013/07/01 09:09:12, stuartmorgan wrote:
> Unused now.

Done.

[Nico, 2013-07-01 17:24:43]

lgtm

https://codereview.chromium.org/18177011/diff/10001/build/mac/copy_asan_runti...
File build/mac/copy_asan_runtime_dylib.sh (right):

https://codereview.chromium.org/18177011/diff/10001/build/mac/copy_asan_runti...
build/mac/copy_asan_runtime_dylib.sh:41: # an iOS gtest app, and the ASan
runtime is to be put next to the executable.
s/to be//

[Alexander Potapenko, 2013-07-02 08:17:30]

Committed patchset #4 manually as r209647 (presubmit successful).