Handle iOS gtest app bundles in copy_asan_runtime_dylib.sh

build/mac/copy_asan_runtime_dylib.sh

 #!/bin/bash
 
 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # For app bundles built with ASan, copies the runtime lib
 # (libclang_rt.asan_osx_dynamic.dylib), on which their executables depend, from
 # the compiler installation path to appname.app/Contents/Resources and fixes the
 # dylib's install name in the binary to be relative to @executable_path.
@@ skipping 17 matching lines @@
   # runtime in ASan.
   exit 0
 fi
 
 DYLIB_BASENAME=$(basename "${ASAN_DYLIB}")
 if [[ "${DYLIB_BASENAME}" != "${ASAN_DYLIB_NAME}" ]]; then
   echo "basename(${ASAN_DYLIB}) != ${ASAN_DYLIB_NAME}" >&2
   exit 1
 fi
 
-LIBRARIES_DIR="$(dirname "${BINARY_DIR}")/Libraries"
-mkdir -p "${LIBRARIES_DIR}"
+# Check whether the directory containing the executable binary has an .app
+# extension. In this case we're probably building an iOS gtest app,
+# otherwise it is a regular OSX application.
+BINARY_DIR_EXT=$(echo "${BINARY_DIR}" | sed 's/^.*\.//')

[Nico, 2013/06/28 19:11:40]

I don't think that's the right check. From what I understand, Mac app bundles
contain a "Contents" folder with the contents of the bundle (and nothing else)
and iOS bundles have all files right in the bundle. So I'd check for a Contents
subfolder instead to differentiate mac and ios bundles.

[Alexander Potapenko, 2013/07/01 08:35:01]

The binary resides in Contents/MacOS, how about checking for "MacOS" (see the
new patchset)?
We can also simply put the runtime library next to the executable (i.e. into
appname.app/Contents/MacOS for rich apps and testname.app/ for tests)

+if [ "$BINARY_DIR_EXT" != "app" ]; then
+  LIBRARIES_DIR="$(dirname "${BINARY_DIR}")/Libraries"
+  mkdir -p "${LIBRARIES_DIR}"
+  NEW_LC_ID_DYLIB="@executable_path/../Libraries/${ASAN_DYLIB_NAME}"
+else
+  LIBRARIES_DIR="${BINARY_DIR}"
+  NEW_LC_ID_DYLIB="@executable_path/${ASAN_DYLIB_NAME}"
+fi
+
 cp "${ASAN_DYLIB}" "${LIBRARIES_DIR}"
 
-NEW_LC_ID_DYLIB="@executable_path/../Libraries/${ASAN_DYLIB_NAME}"
-
 # Make LC_ID_DYLIB of the runtime copy point to its location.
 install_name_tool \
     -id "${NEW_LC_ID_DYLIB}" \
     "${LIBRARIES_DIR}/${ASAN_DYLIB_NAME}"
 
 # Fix the rpath to the runtime library recorded in the binary.
 install_name_tool \
     -change "${BUILTIN_DYLIB_PATH}" \
     "${NEW_LC_ID_DYLIB}" \
     "${BINARY}"