Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: third_party/WebKit/Source/core/layout/PaintInvalidationState.h

Issue 1817693002: Support edge-inclusive intersections in mapToVisibleRectInAncestorSpace (Closed) Base URL: https://chromium.googlesource.com/chromium/src@intersection-observer-idle-callback
Patch Set: Added IntersectionType flag and unit test for LayoutRect::inclusiveIntersect. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/PaintInvalidationState.h
diff --git a/third_party/WebKit/Source/core/layout/PaintInvalidationState.h b/third_party/WebKit/Source/core/layout/PaintInvalidationState.h
index c65acfb8a8e1b4b7809770ce6a0de0e285ee1594..98eab194d7c9e6dd26881829f53e54a5cc491ce0 100644
--- a/third_party/WebKit/Source/core/layout/PaintInvalidationState.h
+++ b/third_party/WebKit/Source/core/layout/PaintInvalidationState.h
@@ -18,6 +18,11 @@ class LayoutSVGModelObject;
class LayoutView;
class PaintLayer;
+enum IntersectionFlags {
+ EdgeExclusive = 0,
eae 2016/03/22 17:54:16 We generally do not have a name for the 0 flag and
szager1 2016/03/22 19:42:24 Changed to DefaultVisibleRectFlags.
+ EdgeInclusive = 1
+};
chrishtr 2016/03/22 17:25:49 Add typedef unsigned IntersectionFlags
szager1 2016/03/22 19:42:24 I changed it to: enum VisibleRectFlags { ...
+
// PaintInvalidationState is an optimization used during the paint
// invalidation phase.
//
@@ -72,7 +77,7 @@ public:
{
return m_cachedOffsetsEnabled && ancestor == &m_paintInvalidationContainer;
}
- void mapObjectRectToAncestor(const LayoutObject&, const LayoutBoxModelObject* ancestor, LayoutRect&) const;
+ bool mapObjectRectToAncestor(const LayoutObject&, const LayoutBoxModelObject* ancestor, LayoutRect&, int flags = 0) const;
// Records |obj| as needing paint invalidation on the next frame. See the definition of PaintInvalidationDelayedFull for more details.
void pushDelayedPaintInvalidationTarget(LayoutObject& obj) const { m_pendingDelayedPaintInvalidations.append(&obj); }

Powered by Google App Engine
This is Rietveld 408576698