Support edge-inclusive intersections in mapToVisibleRectInAncestorSpace

third_party/WebKit/Source/core/layout/PaintInvalidationState.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PaintInvalidationState_h
 #define PaintInvalidationState_h
 
 #include "platform/geometry/LayoutRect.h"
 #include "platform/transforms/AffineTransform.h"
 #include "wtf/Allocator.h"
 #include "wtf/Noncopyable.h"
 
 namespace blink {
 
 class LayoutBoxModelObject;
 class LayoutObject;
 class LayoutSVGModelObject;
 class LayoutView;
 class PaintLayer;
 
+enum IntersectionFlags {
+    EdgeExclusive = 0,

[eae, 2016/03/22 17:54:16]

We generally do not have a name for the 0 flag and if we do it's generally
called something like DefaultIntersectionFlags or NoIntersectionFlags.

Having the 0 value called EdgeExclusive makes it quite confusing if we ever add
another flag.

[szager1, 2016/03/22 19:42:24]

Changed to DefaultVisibleRectFlags.

+    EdgeInclusive = 1
+};

[chrishtr, 2016/03/22 17:25:49]

Add typedef unsigned IntersectionFlags

[szager1, 2016/03/22 19:42:24]

I changed it to:

enum VisibleRectFlags {
  ...

+
 // PaintInvalidationState is an optimization used during the paint
 // invalidation phase.
 //
 // This class is extremely close to LayoutState so see the documentation
 // of LayoutState for the class existence and performance benefits.
 //
 // The main difference with LayoutState is that it was customized for the
 // needs of the paint invalidation systems (keeping visual rectangles
 // instead of layout specific information).
 class PaintInvalidationState {
@@ skipping 34 matching lines @@
 
     bool forcedSubtreeInvalidationRectUpdateWithinContainer() const { return m_forcedSubtreeInvalidationRectUpdateWithinContainer; }
     void setForceSubtreeInvalidationRectUpdateWithinContainer() { m_forcedSubtreeInvalidationRectUpdateWithinContainer = true; }
 
     const LayoutBoxModelObject& paintInvalidationContainer() const { return m_paintInvalidationContainer; }
 
     bool canMapToAncestor(const LayoutBoxModelObject* ancestor) const
     {
         return m_cachedOffsetsEnabled && ancestor == &m_paintInvalidationContainer;
     }
-    void mapObjectRectToAncestor(const LayoutObject&, const LayoutBoxModelObject* ancestor, LayoutRect&) const;
+    bool mapObjectRectToAncestor(const LayoutObject&, const LayoutBoxModelObject* ancestor, LayoutRect&, int flags = 0) const;
 
     // Records |obj| as needing paint invalidation on the next frame. See the definition of PaintInvalidationDelayedFull for more details.
     void pushDelayedPaintInvalidationTarget(LayoutObject& obj) const { m_pendingDelayedPaintInvalidations.append(&obj); }
     Vector<LayoutObject*>& pendingDelayedPaintInvalidationTargets() const { return m_pendingDelayedPaintInvalidations; }
 
     // Disable view clipping and scroll offset adjustment for paint invalidation of FrameView scrollbars.
     // TODO(wangxianzhu): Remove this when root-layer-scrolls launches.
     bool viewClippingAndScrollOffsetDisabled() const { return m_viewClippingAndScrollOffsetDisabled; }
     void setViewClippingAndScrollOffsetDisabled(bool b) { m_viewClippingAndScrollOffsetDisabled = b; }
 
@@ skipping 61 matching lines @@
             m_paintInvalidationState->m_cachedOffsetsEnabled = true;
     }
 private:
     const PaintInvalidationState* m_paintInvalidationState;
     bool m_didDisable;
 };
 
 } // namespace blink
 
 #endif // PaintInvalidationState_h