Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/intersection-observer/edge.html

Issue 1817693002: Support edge-inclusive intersections in mapToVisibleRectInAncestorSpace (Closed) Base URL: https://chromium.googlesource.com/chromium/src@intersection-observer-idle-callback
Patch Set: Added IntersectionType flag and unit test for LayoutRect::inclusiveIntersect. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/intersection-observer/edge-expected.txt » ('j') | third_party/WebKit/Source/core/layout/LayoutObject.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/intersection-observer/edge.html
diff --git a/third_party/WebKit/LayoutTests/intersection-observer/edge.html b/third_party/WebKit/LayoutTests/intersection-observer/edge.html
new file mode 100644
index 0000000000000000000000000000000000000000..fa15f180fc7464f8f7d3b791d6a3c37de614fcb1
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/intersection-observer/edge.html
@@ -0,0 +1,95 @@
+<!DOCTYPE html>
+<script src="../resources/js-test.js"></script>
+<script src="helper-functions.js"></script>
+<style>
+#root {
+ width: 200px;
+ height: 200px;
+ overflow: visible;
+}
+#target {
+ background-color: green;
+}
+</style>
+<div id="root">
+ <div id="target" style="width: 100px; height: 100px; transform: translateY(250px)"></div>
+</div>
+
+<script>
+description("Verifies that IntersectionObserver detects edge-inclusive intersections.");
+var root = document.getElementById('root');
+var target = document.getElementById('target');
+var entries = [];
+var observer = new IntersectionObserver(
+ changes => { entries.push(...changes) },
+ { root: root }
+);
+
+onload = function() {
+ observer.observe(target);
+ entries.push(...observer.takeRecords());
+ shouldBeEqualToNumber("entries.length", 0);
+ requestAnimationFrame(() => { requestAnimationFrame(step0) });
+};
+
+function step0() {
+ entries.push(...observer.takeRecords());
+ shouldBeEqualToNumber("entries.length", 0);
+ target.style.transform = "translateY(200px)";
+ requestAnimationFrame(step1);
+}
+
+function step1() {
+ entries.push(...observer.takeRecords());
+ shouldBeEqualToNumber("entries.length", 1);
+ if (entries.length > 0) {
+ shouldBeEqualToNumber("entries[0].boundingClientRect.left", 8);
+ shouldBeEqualToNumber("entries[0].boundingClientRect.right", 108);
+ shouldBeEqualToNumber("entries[0].boundingClientRect.top", 208);
+ shouldBeEqualToNumber("entries[0].boundingClientRect.bottom", 308);
+ shouldBeEqualToNumber("entries[0].intersectionRect.left", 8);
+ shouldBeEqualToNumber("entries[0].intersectionRect.right", 108);
+ shouldBeEqualToNumber("entries[0].intersectionRect.top", 208);
+ shouldBeEqualToNumber("entries[0].intersectionRect.bottom", 208);
+ shouldBeEqualToNumber("entries[0].rootBounds.left", 8);
+ shouldBeEqualToNumber("entries[0].rootBounds.right", 208);
+ shouldBeEqualToNumber("entries[0].rootBounds.top", 8);
+ shouldBeEqualToNumber("entries[0].rootBounds.bottom", 208);
+ shouldEvaluateToSameObject("entries[0].target", target);
+ }
+ target.style.transform = "translateY(201px)";
+ requestAnimationFrame(step2);
+}
+
+function step2() {
+ entries.push(...observer.takeRecords());
+ shouldBeEqualToNumber("entries.length", 2);
+ target.style.height = "0px";
+ target.style.width = "300px";
+ target.style.transform = "translateY(185px)";
+ requestAnimationFrame(step3);
+}
+
+function step3() {
+ entries.push(...observer.takeRecords());
+ shouldBeEqualToNumber("entries.length", 3);
+ if (entries.length > 2) {
+ shouldBeEqualToNumber("entries[2].boundingClientRect.left", 8);
+ shouldBeEqualToNumber("entries[2].boundingClientRect.right", 308);
+ shouldBeEqualToNumber("entries[2].boundingClientRect.top", 193);
+ shouldBeEqualToNumber("entries[2].boundingClientRect.bottom", 193);
+ shouldBeEqualToNumber("entries[2].intersectionRect.left", 8);
+ shouldBeEqualToNumber("entries[2].intersectionRect.right", 208);
+ shouldBeEqualToNumber("entries[2].intersectionRect.top", 193);
+ shouldBeEqualToNumber("entries[2].intersectionRect.bottom", 193);
+ shouldBeEqualToNumber("entries[2].rootBounds.left", 8);
+ shouldBeEqualToNumber("entries[2].rootBounds.right", 208);
+ shouldBeEqualToNumber("entries[2].rootBounds.top", 8);
+ shouldBeEqualToNumber("entries[2].rootBounds.bottom", 208);
+ shouldEvaluateToSameObject("entries[2].target", target);
+ }
+
+ // See README for explanation of this requestIdleCallback.
+ requestIdleCallback(finishJSTest, {timeout: 100});
+}
+</script>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/intersection-observer/edge-expected.txt » ('j') | third_party/WebKit/Source/core/layout/LayoutObject.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698