Process Alternative Service headers in net::BidirectionalStream

Process Alternative Service headers in net::BidirectionalStream

This CL adds processing of alternative service headers to
net::BidirectionalStream, so that protocols advertised in
alternative service headers can be discovered.

BUG=584338
Committed: https://crrev.com/b3a648e3abbf08d0b08ba9cf1b273ef0e960b748
Cr-Commit-Position: refs/heads/master@{#382501}

[xunjieli, 2016-03-18 18:44:54]

Description was changed from

==========
Process Alternative Service headers in net::BidirectionalStream

This CL adds processing of alternative service headers to
net::BidirectionalStream, so that protocols advertised in alternative service
headers can be discovered.

BUG=584338
==========

to

==========
Process Alternative Service headers in net::BidirectionalStream

This CL adds processing of alternative service headers to
net::BidirectionalStream, so that protocols advertised in 
alternative service headers can be discovered.

BUG=584338
==========

[xunjieli, 2016-03-18 18:48:22]

Patchset #1 (id:1) has been deleted

[xunjieli, 2016-03-18 18:52:35]

xunjieli@chromium.org changed reviewers:
+ mef@chromium.org, rch@chromium.org

[xunjieli, 2016-03-18 18:52:36]

PTAL. Thanks!

[Ryan Hamilton, 2016-03-18 20:54:58]

lgtm, though please wait for mef who probably has more context.

One question.

https://codereview.chromium.org/1817583002/diff/20001/net/http/http_stream_fa...
File net/http/http_stream_factory.cc (right):

https://codereview.chromium.org/1817583002/diff/20001/net/http/http_stream_fa...
net/http/http_stream_factory.cc:73: GURL
HttpStreamFactory::ApplyHostMappingRules(const GURL& url,
Does this method need to move as part of this CL?

[xunjieli, 2016-03-18 21:01:27]

https://codereview.chromium.org/1817583002/diff/20001/net/http/http_stream_fa...
File net/http/http_stream_factory.cc (right):

https://codereview.chromium.org/1817583002/diff/20001/net/http/http_stream_fa...
net/http/http_stream_factory.cc:73: GURL
HttpStreamFactory::ApplyHostMappingRules(const GURL& url,
On 2016/03/18 20:54:58, Ryan Hamilton wrote:
> Does this method need to move as part of this CL?

I was tricked too! The diffing tool is being weird. I actually moved
ProcessAlternativeService and ProcessAlternateProtocol down, because they are
now private methods, and I make them match declared order. The diffing tool
doesn't pick up that, and instead it thinks that I moved ApplyHostMappingRules +
HttpStreamFactory() to the top.

[mef, 2016-03-21 22:21:56]

lgtm

https://codereview.chromium.org/1817583002/diff/40001/net/http/http_stream_fa...
File net/http/http_stream_factory.h (right):

https://codereview.chromium.org/1817583002/diff/40001/net/http/http_stream_fa...
net/http/http_stream_factory.h:42: class HttpResponseHeaders;
nit: I think this should go up one line.

[xunjieli, 2016-03-22 02:23:18]

The CQ bit was checked by xunjieli@chromium.org

[xunjieli, 2016-03-22 02:23:18]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1817583002/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2016-03-22 02:23:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1817583002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1817583002/40001

[xunjieli, 2016-03-22 02:24:00]

The CQ bit was unchecked by xunjieli@chromium.org

[xunjieli, 2016-03-22 02:29:00]

https://codereview.chromium.org/1817583002/diff/40001/net/http/http_stream_fa...
File net/http/http_stream_factory.h (right):

https://codereview.chromium.org/1817583002/diff/40001/net/http/http_stream_fa...
net/http/http_stream_factory.h:42: class HttpResponseHeaders;
On 2016/03/21 22:21:56, mef wrote:
> nit: I think this should go up one line.

Done.

[xunjieli, 2016-03-22 02:29:50]

The CQ bit was checked by xunjieli@chromium.org

[xunjieli, 2016-03-22 02:29:50]

The patchset sent to the CQ was uploaded after l-g-t-m from mef@chromium.org,
rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1817583002/#ps60001
(title: "Address comments and rebased")

[commit-bot: I haz the power, 2016-03-22 02:30:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1817583002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1817583002/60001

[commit-bot: I haz the power, 2016-03-22 03:40:00]

Description was changed from

==========
Process Alternative Service headers in net::BidirectionalStream

This CL adds processing of alternative service headers to
net::BidirectionalStream, so that protocols advertised in 
alternative service headers can be discovered.

BUG=584338
==========

to

==========
Process Alternative Service headers in net::BidirectionalStream

This CL adds processing of alternative service headers to
net::BidirectionalStream, so that protocols advertised in 
alternative service headers can be discovered.

BUG=584338
==========

[commit-bot: I haz the power, 2016-03-22 03:40:01]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-03-22 03:42:21]

Description was changed from

==========
Process Alternative Service headers in net::BidirectionalStream

This CL adds processing of alternative service headers to
net::BidirectionalStream, so that protocols advertised in 
alternative service headers can be discovered.

BUG=584338
==========

to

==========
Process Alternative Service headers in net::BidirectionalStream

This CL adds processing of alternative service headers to
net::BidirectionalStream, so that protocols advertised in
alternative service headers can be discovered.

BUG=584338

Committed: https://crrev.com/b3a648e3abbf08d0b08ba9cf1b273ef0e960b748
Cr-Commit-Position: refs/heads/master@{#382501}
==========

[commit-bot: I haz the power, 2016-03-22 03:42:22]

Patchset 3 (id:??) landed as
https://crrev.com/b3a648e3abbf08d0b08ba9cf1b273ef0e960b748
Cr-Commit-Position: refs/heads/master@{#382501}