Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: net/http/http_network_transaction.cc

Issue 1817583002: Process Alternative Service headers in net::BidirectionalStream (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@toggle2
Patch Set: Address comments and rebased Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/bidirectional_stream_unittest.cc ('k') | net/http/http_stream_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_network_transaction.cc
diff --git a/net/http/http_network_transaction.cc b/net/http/http_network_transaction.cc
index 14da6c704043fa978c227136eaa45191ce371729..41c1acffc4fba2406a6ccc81dfeb583f0520cd83 100644
--- a/net/http/http_network_transaction.cc
+++ b/net/http/http_network_transaction.cc
@@ -71,44 +71,6 @@ namespace net {
namespace {
-void ProcessAlternativeServices(HttpNetworkSession* session,
- const HttpResponseHeaders& headers,
- const HostPortPair& http_host_port_pair) {
- if (session->params().parse_alternative_services) {
- if (headers.HasHeader(kAlternativeServiceHeader)) {
- std::string alternative_service_str;
- headers.GetNormalizedHeader(kAlternativeServiceHeader,
- &alternative_service_str);
- session->http_stream_factory()->ProcessAlternativeService(
- session->http_server_properties(), alternative_service_str,
- http_host_port_pair, *session);
- }
- // If "Alt-Svc" is enabled, then ignore "Alternate-Protocol".
- return;
- }
-
- if (!headers.HasHeader(kAlternateProtocolHeader))
- return;
-
- std::vector<std::string> alternate_protocol_values;
- size_t iter = 0;
- std::string alternate_protocol_str;
- while (headers.EnumerateHeader(&iter, kAlternateProtocolHeader,
- &alternate_protocol_str)) {
- base::TrimWhitespaceASCII(alternate_protocol_str, base::TRIM_ALL,
- &alternate_protocol_str);
- if (!alternate_protocol_str.empty()) {
- alternate_protocol_values.push_back(alternate_protocol_str);
- }
- }
-
- session->http_stream_factory()->ProcessAlternateProtocol(
- session->http_server_properties(),
- alternate_protocol_values,
- http_host_port_pair,
- *session);
-}
-
scoped_ptr<base::Value> NetLogSSLVersionFallbackCallback(
const GURL* url,
int net_error,
@@ -1238,8 +1200,8 @@ int HttpNetworkTransaction::DoReadHeadersComplete(int result) {
return OK;
}
- ProcessAlternativeServices(session_, *response_.headers.get(),
- HostPortPair::FromURL(request_->url));
+ session_->http_stream_factory()->ProcessAlternativeServices(
+ session_, response_.headers.get(), HostPortPair::FromURL(request_->url));
int rv = HandleAuthChallenge();
if (rv != OK)
« no previous file with comments | « net/http/bidirectional_stream_unittest.cc ('k') | net/http/http_stream_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698