components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamQuicTest.java - Issue 1817553002: Add host resolver rules experimental flag for Cronet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamQuicTest.java

Issue 1817553002: Add host resolver rules experimental flag for Cronet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: delete unused definitions, rebase, and fix test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamQuicTest.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamQuicTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamQuicTest.java

index 3eff9e73c863cd75b4b85b9c904df6099293ab66..021d35ef1c02fd8b76c933c198704f9a1c536632 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamQuicTest.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamQuicTest.java

@@ -34,7 +34,10 @@ public class BidirectionalStreamQuicTest extends CronetTestBase {

if (enabled == QuicBidirectionalStreams.DISABLED) {

quicParams.put("quic_disable_bidirectional_streams", true);

}

- JSONObject experimentalOptions = new JSONObject().put("QUIC", quicParams);

+ JSONObject hostResolverParams = CronetTestUtil.generateHostResolverRules();

+ JSONObject experimentalOptions = new JSONObject()

+ .put("QUIC", quicParams)

+ .put("HostResolverRules", hostResolverParams);

builder.setExperimentalOptions(experimentalOptions.toString());

builder.addQuicHint(QuicTestServer.getServerHost(), QuicTestServer.getServerPort(),

@@ -43,7 +46,6 @@ public class BidirectionalStreamQuicTest extends CronetTestBase {

builder.setMockCertVerifierForTesting(QuicTestServer.createMockCertVerifier());

mTestFramework = startCronetTestFrameworkWithUrlAndCronetEngineBuilder(null, builder);

- registerHostResolver(mTestFramework);

}

@Override