components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java - Issue 1817553002: Add host resolver rules experimental flag for Cronet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java

Issue 1817553002: Add host resolver rules experimental flag for Cronet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: delete unused definitions, rebase, and fix test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/test/cronet_test_util.cc ('k') | components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamQuicTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java

diff --git a/components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java b/components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java

index 8366ad5d5537f899a3960657eec6468b11849c28..0ca39e04d70f29fd8d97a5c32be5f01f20f4c461 100644

--- a/components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java

+++ b/components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java

@@ -199,13 +199,17 @@ public class CronetPerfTestActivity extends Activity {

try {

JSONObject quicParams = new JSONObject().put("host_whitelist", host);

- JSONObject experimentalOptions = new JSONObject().put("QUIC", quicParams);

+ JSONObject hostResolverParams =

+ CronetTestUtil.generateHostResolverRules(getConfigString("HOST_IP"));

+ JSONObject experimentalOptions =

+ new JSONObject()

+ .put("QUIC", quicParams)

+ .put("HostResolverRules", hostResolverParams);

cronetEngineBuilder.setExperimentalOptions(experimentalOptions.toString());

} catch (JSONException e) {

throw new IllegalStateException("JSON failed: " + e);

}

mCronetEngine = cronetEngineBuilder.build();

- CronetTestUtil.registerHostResolverProc(mCronetEngine, getConfigString("HOST_IP"));

mName = buildBenchmarkName(mode, direction, protocol, concurrency, mIterations);

mConcurrency = concurrency;

mResults = results;