Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1817523002: Speed up clearing of old to new slots in dead objects. (Closed)

Created:
4 years, 9 months ago by ulan
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Speed up clearing of old to new slots in dead objects. Since we clear invalid slots eagerly, there is no need to check if a slot is a valid slot. BUG=chromium:578883 LOG=NO Committed: https://crrev.com/4526365f5355ebe06edfb32c1944adb0e1c6f019 Cr-Commit-Position: refs/heads/master@{#34898}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -46 lines) Patch
M src/heap/mark-compact.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/heap/mark-compact.cc View 1 3 chunks +3 lines, -37 lines 0 comments Download
M src/heap/remembered-set.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/remembered-set.cc View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
ulan
PTAL https://codereview.chromium.org/1817523002/diff/1/src/heap/mark-compact.cc File src/heap/mark-compact.cc (left): https://codereview.chromium.org/1817523002/diff/1/src/heap/mark-compact.cc#oldcode2973 src/heap/mark-compact.cc:2973: return object->IsValidSlot(offset); This is the main change.
4 years, 9 months ago (2016-03-18 14:19:42 UTC) #2
Hannes Payer (out of office)
lgtm
4 years, 9 months ago (2016-03-18 14:52:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817523002/1
4 years, 9 months ago (2016-03-18 14:59:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/15472) v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, ...
4 years, 9 months ago (2016-03-18 15:02:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817523002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817523002/20001
4 years, 9 months ago (2016-03-18 15:04:38 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-18 15:27:43 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 15:28:24 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4526365f5355ebe06edfb32c1944adb0e1c6f019
Cr-Commit-Position: refs/heads/master@{#34898}

Powered by Google App Engine
This is Rietveld 408576698