Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1583)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1817443002: Rename mash_shell to mash_session. (Closed)

Created:
4 years, 9 months ago by Ben Goodger (Google)
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename mash_shell to mash_session. TBR=sky@chromium.org BUG= Committed: https://crrev.com/c740d5b9a7455a94ddce3835561aa2eb22942b7b Cr-Commit-Position: refs/heads/master@{#381889}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -439 lines) Patch
M ash/shelf/shelf_layout_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/app/mash/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/app/mash/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/mash/mash_runner.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M mash/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mash/example/window_type_launcher/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M mash/login/login.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/screenlock/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mash/screenlock/screenlock.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mash/screenlock/screenlock.cc View 3 chunks +7 lines, -7 lines 0 comments Download
A + mash/session/BUILD.gn View 4 chunks +7 lines, -7 lines 0 comments Download
A + mash/session/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A mash/session/manifest.json View 1 chunk +8 lines, -0 lines 0 comments Download
A + mash/session/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mash/session/public/interfaces/session.mojom View 2 chunks +2 lines, -2 lines 0 comments Download
A + mash/session/session.h View 5 chunks +16 lines, -17 lines 0 comments Download
A + mash/session/session.cc View 7 chunks +30 lines, -33 lines 0 comments Download
D mash/shell/BUILD.gn View 1 chunk +0 lines, -60 lines 0 comments Download
D mash/shell/main.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D mash/shell/manifest.json View 1 chunk +0 lines, -5 lines 0 comments Download
D mash/shell/public/interfaces/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
D mash/shell/public/interfaces/shell.mojom View 1 chunk +0 lines, -19 lines 0 comments Download
D mash/shell/shell_application_delegate.h View 1 chunk +0 lines, -78 lines 0 comments Download
D mash/shell/shell_application_delegate.cc View 1 chunk +0 lines, -141 lines 0 comments Download
M mash/wm/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M mash/wm/root_window_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mash/wm/window_manager.h View 3 chunks +4 lines, -4 lines 0 comments Download
M mash/wm/window_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mash/wm/window_manager_application.h View 3 chunks +4 lines, -4 lines 0 comments Download
M mash/wm/window_manager_application.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817443002/1
4 years, 9 months ago (2016-03-18 03:12:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 04:54:34 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c740d5b9a7455a94ddce3835561aa2eb22942b7b Cr-Commit-Position: refs/heads/master@{#381889}
4 years, 9 months ago (2016-03-18 04:56:23 UTC) #5
sky
4 years, 9 months ago (2016-03-18 15:56:40 UTC) #6
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698