Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2525)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 18174010: Test running changes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/language/language_analyzer.status ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 1cae1d7773c8e79629eb85a3e4fb0b962accf879..2a26836c5642a7f68a3433fd28ae0333bd03b915 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -850,7 +850,9 @@ class AnalysisCommandOutputImpl extends CommandOutputImpl {
} else if (fields[ERROR_LEVEL] == 'WARNING') {
// We only care about testing Static type warnings
// ignore all others
kustermann 2013/07/01 06:24:17 This comment seems to be wrong now. Is there a re
scheglov 2013/07/01 07:04:30 Thank you, fixed.
- if (fields[ERROR_TYPE] == 'STATIC_TYPE' || fields[ERROR_TYPE] == 'STATIC_TYPE_WARNING') {
+ if (fields[ERROR_TYPE] == 'STATIC_TYPE' ||
+ fields[ERROR_TYPE] == 'STATIC_WARNING' ||
+ fields[ERROR_TYPE] == 'STATIC_TYPE_WARNING') {
staticWarnings.add(fields[FORMATTED_ERROR]);
}
}
« no previous file with comments | « tests/language/language_analyzer.status ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698