Test running changes.

tools/testing/dart/test_runner.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for executing tests.
  *
  * This module includes:
  * - Managing parallel execution of tests, including timeout checks.
  * - Evaluating the output of each test as pass/fail/crash/timeout.
@@ skipping 831 matching lines @@
 
     // Read the returned list of errors and stuff them away.
     var stderrLines = decodeUtf8(super.stderr).split("\n");
     for (String line in stderrLines) {
       if (line.length == 0) continue;
       List<String> fields = splitMachineError(line);
       if (fields[ERROR_LEVEL] == 'ERROR') {
         errors.add(fields[FORMATTED_ERROR]);
       } else if (fields[ERROR_LEVEL] == 'WARNING') {
         // We only care about testing Static type warnings
         // ignore all others

[kustermann, 2013/07/01 06:24:17]

This comment seems to be wrong now.

Is there a reason why you switch on the 'ERROR_TYPE'. If you want all warnings
to be reported as warnings, you should do:
  if (fields[ERROR_LEVEL] == 'ERROR') {
    errors.add(fields[FORMATTED_ERROR]);
  } else if (fields[ERROR_LEVEL] == 'WARNING') {
    warnings.add(fields[FORMATTED_ERROR]);
  }

Are there other kinds of warnings we want to ignore?

[scheglov, 2013/07/01 07:04:30]

  Thank you, fixed.

-        if (fields[ERROR_TYPE] == 'STATIC_TYPE' || fields[ERROR_TYPE] == 'STATIC_TYPE_WARNING') {
+        if (fields[ERROR_TYPE] == 'STATIC_TYPE' ||
+            fields[ERROR_TYPE] == 'STATIC_WARNING' ||
+            fields[ERROR_TYPE] == 'STATIC_TYPE_WARNING') {
           staticWarnings.add(fields[FORMATTED_ERROR]);
         }
       }
       // OK to Skip error output that doesn't match the machine format
     }
     if (testCase.info != null
         && testCase.info.optionsFromFile['isMultitest']) {
       return _didMultitestFail(errors, staticWarnings);
     }
     return _didStandardTestFail(errors, staticWarnings);
@@ skipping 1049 matching lines @@
     }
   }
 
   void eventAllTestsDone() {
     for (var listener in _eventListener) {
       listener.allDone();
     }
   }
 }