|
|
Revert of Remove create/delete methods from WebGraphicsContext3D. (patchset #6 id:100001 of https://codereview.chromium.org/1814263004/ )
Reason for revert:
FAILED: [snip]
../../third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp:255:27: error: unused variable 'webContext' [-Werror,-Wunused-variable]
WebGraphicsContext3D* webContext = context();
^
../../third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp:276:27: error: unused variable 'webContext' [-Werror,-Wunused-variable]
WebGraphicsContext3D* webContext = context();
^
2 errors generated.
Original issue's description:
> Remove create/delete methods from WebGraphicsContext3D.
>
> Have callers use the new Gen/Delete methods on GLES2Interface instead.
>
> R=bajones@chromium.org, chrishtr@chromium.org, kbr@chromium.org, pfeldman@chromium.org
> TBR=pfeldman
> BUG= 584497
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/d8fb03aaed3416b77589c154ae1e9c2c832bfa4b
> Cr-Commit-Position: refs/heads/master@{#382506}
TBR=chrishtr@chromium.org,bajones@chromium.org,kbr@chromium.org,pfeldman@chromium.org,piman@chromium.org,danakj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 584497
Committed: https://crrev.com/0f1ab8d1aa55795c6c4eb5546c4dd24dbb2424c8
Cr-Commit-Position: refs/heads/master@{#382507}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+317 lines, -153 lines) |
Patch |
 |
M |
components/test_runner/DEPS
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
components/test_runner/test_plugin.h
|
View
|
|
5 chunks |
+10 lines, -11 lines |
0 comments
|
Download
|
 |
M |
components/test_runner/test_plugin.cc
|
View
|
|
7 chunks |
+16 lines, -16 lines |
0 comments
|
Download
|
 |
M |
gpu/blink/webgraphicscontext3d_impl.h
|
View
|
|
3 chunks |
+24 lines, -0 lines |
0 comments
|
Download
|
 |
M |
gpu/blink/webgraphicscontext3d_impl.cc
|
View
|
|
3 chunks |
+90 lines, -0 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/webgl/CHROMIUMValuebuffer.cpp
|
View
|
|
2 chunks |
+2 lines, -5 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/webgl/WebGLBuffer.cpp
|
View
|
|
3 chunks |
+2 lines, -5 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp
|
View
|
|
5 chunks |
+12 lines, -12 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp
|
View
|
|
2 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/webgl/WebGLQuery.cpp
|
View
|
|
2 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/webgl/WebGLRenderbuffer.cpp
|
View
|
|
2 chunks |
+2 lines, -5 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
|
View
|
|
3 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/webgl/WebGLSampler.cpp
|
View
|
|
2 chunks |
+2 lines, -5 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/webgl/WebGLTexture.cpp
|
View
|
|
3 chunks |
+2 lines, -5 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/webgl/WebGLTimerQueryEXT.cpp
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/webgl/WebGLTransformFeedback.cpp
|
View
|
|
2 chunks |
+2 lines, -5 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.cpp
|
View
|
|
3 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
|
View
|
|
2 chunks |
+7 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
|
View
|
|
11 chunks |
+30 lines, -17 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp
|
View
|
|
4 chunks |
+26 lines, -34 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/platform/graphics/gpu/SharedContextRateLimiter.cpp
|
View
|
|
3 chunks |
+6 lines, -5 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/platform/graphics/test/MockWebGraphicsContext3D.h
|
View
|
|
1 chunk |
+39 lines, -0 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/public/platform/WebGraphicsContext3D.h
|
View
|
|
2 chunks |
+26 lines, -0 lines |
0 comments
|
Download
|
Total messages: 6 (2 generated)
|