Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Side by Side Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderbuffer.cpp

Issue 1817323003: Revert of Remove create/delete methods from WebGraphicsContext3D. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@complex-casts
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #include "modules/webgl/WebGLRenderbuffer.h" 26 #include "modules/webgl/WebGLRenderbuffer.h"
27 27
28 #include "gpu/command_buffer/client/gles2_interface.h"
29 #include "modules/webgl/WebGLRenderingContextBase.h" 28 #include "modules/webgl/WebGLRenderingContextBase.h"
30 29
31 namespace blink { 30 namespace blink {
32 31
33 WebGLRenderbuffer* WebGLRenderbuffer::create(WebGLRenderingContextBase* ctx) 32 WebGLRenderbuffer* WebGLRenderbuffer::create(WebGLRenderingContextBase* ctx)
34 { 33 {
35 return new WebGLRenderbuffer(ctx); 34 return new WebGLRenderbuffer(ctx);
36 } 35 }
37 36
38 WebGLRenderbuffer::~WebGLRenderbuffer() 37 WebGLRenderbuffer::~WebGLRenderbuffer()
39 { 38 {
40 // See the comment in WebGLObject::detachAndDeleteObject(). 39 // See the comment in WebGLObject::detachAndDeleteObject().
41 detachAndDeleteObject(); 40 detachAndDeleteObject();
42 } 41 }
43 42
44 WebGLRenderbuffer::WebGLRenderbuffer(WebGLRenderingContextBase* ctx) 43 WebGLRenderbuffer::WebGLRenderbuffer(WebGLRenderingContextBase* ctx)
45 : WebGLSharedPlatform3DObject(ctx) 44 : WebGLSharedPlatform3DObject(ctx)
46 , m_internalFormat(GL_RGBA4) 45 , m_internalFormat(GL_RGBA4)
47 , m_width(0) 46 , m_width(0)
48 , m_height(0) 47 , m_height(0)
49 , m_hasEverBeenBound(false) 48 , m_hasEverBeenBound(false)
50 { 49 {
51 GLuint rbo; 50 setObject(ctx->webContext()->createRenderbuffer());
52 ctx->contextGL()->GenRenderbuffers(1, &rbo);
53 setObject(rbo);
54 } 51 }
55 52
56 void WebGLRenderbuffer::deleteObjectImpl(WebGraphicsContext3D* context3d, gpu::g les2::GLES2Interface* gl) 53 void WebGLRenderbuffer::deleteObjectImpl(WebGraphicsContext3D* context3d, gpu::g les2::GLES2Interface* gl)
57 { 54 {
58 gl->DeleteRenderbuffers(1, &m_object); 55 context3d->deleteRenderbuffer(m_object);
59 m_object = 0; 56 m_object = 0;
60 } 57 }
61 58
62 DEFINE_TRACE(WebGLRenderbuffer) 59 DEFINE_TRACE(WebGLRenderbuffer)
63 { 60 {
64 WebGLSharedPlatform3DObject::trace(visitor); 61 WebGLSharedPlatform3DObject::trace(visitor);
65 } 62 }
66 63
67 } // namespace blink 64 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698