chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc - Issue 1817263003: Allow TimeTicks for serialized page load operations to be equal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc

Issue 1817263003: Allow TimeTicks for serialized page load operations to be equal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add param Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc ('k') | components/page_load_metrics/browser/metrics_web_contents_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc

index b0217041ca135b3d6104a71d59838b138d8b27c8..39cbf59599048cd1449895f646d3ef78d44376f3 100644

--- a/chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc

@@ -28,21 +28,21 @@ void StaleWhileRevalidateMetricsObserver::OnComplete(

if (!is_interesting_domain_)

return;

- if (WasStartedInForegroundEventInForeground(timing.load_event_start,

+ if (WasStartedInForegroundEventInForeground(timing.load_event_start, false,

extra_info)) {

PAGE_LOAD_HISTOGRAM(

"PageLoad.Clients.StaleWhileRevalidateExperiment.Timing2."

"NavigationToLoadEventFired",

timing.load_event_start);

}

- if (WasStartedInForegroundEventInForeground(timing.first_layout,

+ if (WasStartedInForegroundEventInForeground(timing.first_layout, false,

extra_info)) {

PAGE_LOAD_HISTOGRAM(

"PageLoad.Clients.StaleWhileRevalidateExperiment.Timing2."

"NavigationToFirstLayout",

timing.first_layout);

}

- if (WasStartedInForegroundEventInForeground(timing.first_text_paint,

+ if (WasStartedInForegroundEventInForeground(timing.first_text_paint, false,

extra_info)) {

PAGE_LOAD_HISTOGRAM(

"PageLoad.Clients.StaleWhileRevalidateExperiment.Timing2."