Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc

Issue 1817263003: Allow TimeTicks for serialized page load operations to be equal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add param Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
index 34a8aec95ab20fefdfadb6efe338882552910b40..267f0abce4cfe1e9491b18a231abd4b9a60defc6 100644
--- a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
@@ -71,7 +71,7 @@ void FromGWSPageLoadMetricsObserver::OnComplete(
return;
if (WasStartedInForegroundEventInForeground(
- timing.dom_content_loaded_event_start, extra_info)) {
+ timing.dom_content_loaded_event_start, false, extra_info)) {
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.FromGWS.Timing2."
"NavigationToDOMContentLoadedEventFired",
@@ -81,37 +81,38 @@ void FromGWSPageLoadMetricsObserver::OnComplete(
"DOMLoadingToDOMContentLoadedEventFired",
timing.dom_content_loaded_event_start - timing.dom_loading);
}
- if (WasStartedInForegroundEventInForeground(timing.load_event_start,
+ if (WasStartedInForegroundEventInForeground(timing.load_event_start, false,
extra_info)) {
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.FromGWS.Timing2.NavigationToLoadEventFired",
timing.load_event_start);
}
- if (WasStartedInForegroundEventInForeground(timing.first_layout,
+ if (WasStartedInForegroundEventInForeground(timing.first_layout, false,
extra_info)) {
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.FromGWS.Timing2.NavigationToFirstLayout",
timing.first_layout);
}
- if (WasStartedInForegroundEventInForeground(timing.first_text_paint,
+ if (WasStartedInForegroundEventInForeground(timing.first_text_paint, false,
extra_info)) {
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.FromGWS.Timing2.NavigationToFirstTextPaint",
timing.first_text_paint);
}
- if (WasStartedInForegroundEventInForeground(timing.first_image_paint,
+ if (WasStartedInForegroundEventInForeground(timing.first_image_paint, false,
extra_info)) {
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.FromGWS.Timing2.NavigationToFirstImagePaint",
timing.first_image_paint);
}
- if (WasStartedInForegroundEventInForeground(timing.first_paint, extra_info)) {
+ if (WasStartedInForegroundEventInForeground(timing.first_paint, false,
+ extra_info)) {
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.FromGWS.Timing2.NavigationToFirstPaint",
timing.first_paint);
}
if (WasStartedInForegroundEventInForeground(timing.first_contentful_paint,
- extra_info)) {
+ false, extra_info)) {
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.FromGWS.Timing2.NavigationToFirstContentfulPaint",
timing.first_contentful_paint);

Powered by Google App Engine
This is Rietveld 408576698