Chromium Code Reviews| Index: test/cctest/test-parsing.cc |
| diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc |
| index 37c60d0d61eb40bd82d0dcda790d21e109502a3e..cedc6754c8164020d8b136aa5c41de0faa14b7b7 100644 |
| --- a/test/cctest/test-parsing.cc |
| +++ b/test/cctest/test-parsing.cc |
| @@ -7549,3 +7549,88 @@ TEST(TypedModeTupleTypes) { |
| RunParserSyncTest(typed_context_data, error_data, kError, NULL, 0, |
| always_flags, arraysize(always_flags)); |
| } |
| + |
| +TEST(TypedModeObjectTypes) { |
| + const char* untyped_context_data[][2] = {{"", ""}, {NULL, NULL}}; |
| + const char* typed_context_data[][2] = {{"'use types'; ", ""}, {NULL, NULL}}; |
| + |
| + const char* correct_data[] = { |
| + "var x: {}", |
| + "var x: {a}", |
| + "var x: {a, b}", |
| + "var x: {a, b?, c}", |
| + "var x: {a: number}", |
| + "var x: {a: number, b: string}", |
| + "var x: {a?: number; b: {c: any}}", |
| + "var x: {f()}", |
| + "var x: {f() : number}", |
| + "var x: {f(a, b)}", |
| + "var x: {f(a: number, b: string)}", |
| + "var x: {f(a: number, b: string) : boolean}", |
| + "var x: {f?(a: number, b: string) : boolean}", |
| + "var x: {f<A extends number>(a: A, b: string) : boolean}", |
|
rossberg
2016/04/07 15:09:02
Perhaps add a case without extends clause.
nickie
2016/04/08 09:50:57
Done.
|
| + "var x: {f?<A extends number>(a: A, b: string) : boolean}", |
| + "var x: {()}", |
| + "var x: {() : number}", |
| + "var x: {(a, b)}", |
| + "var x: {(a: number, b: string)}", |
| + "var x: {(a: number, b: string) : boolean}", |
| + "var x: {<A extends number>(a: A, b: string) : boolean}", |
| + "var x: {new (a, b)}", |
| + "var x: {new (a: number, b: string)}", |
| + "var x: {new (a: number, b: string) : boolean}", |
| + "var x: {new <A extends number>(a: A, b: string) : boolean}", |
| + NULL |
| + }; |
| + |
| + const char* error_data[] = { |
| + "var z: {a: ()}", // Not valid in general. |
| + "var z: {a: []}", // Valid as a binding pattern, not as a type. |
|
rossberg
2016/04/07 15:09:02
Perhaps add things like
f<>()
f<A>
f<A>: A
nickie
2016/04/08 09:50:57
Done.
|
| + NULL |
| + }; |
| + |
| + static const ParserFlag always_flags[] = {kAllowTypes}; |
| + RunParserSyncTest(untyped_context_data, correct_data, kError, NULL, 0, |
| + always_flags, arraysize(always_flags)); |
| + RunParserSyncTest(typed_context_data, correct_data, kSuccess, NULL, 0, |
| + always_flags, arraysize(always_flags)); |
| + RunParserSyncTest(untyped_context_data, error_data, kError, NULL, 0, |
| + always_flags, arraysize(always_flags)); |
| + RunParserSyncTest(typed_context_data, error_data, kError, NULL, 0, |
| + always_flags, arraysize(always_flags)); |
| +} |
| + |
| +TEST(TypedModeBindingPatterns) { |
| + const char* untyped_context_data[][2] = {{"", ""}, {NULL, NULL}}; |
| + const char* typed_context_data[][2] = {{"'use types'; ", ""}, {NULL, NULL}}; |
| + |
| + const char* correct_data[] = { |
| + "var f: (x: number, cmd?: 'two', ...rest) => string", |
| + "var f: ([]: number[]) => boolean", |
| + "var f: ([x, y]: number[]) => boolean", |
| + "var f: ([x, ...rest]: number[]) => boolean", |
| + "var f: ([,x, y]: number[]) => boolean", |
| + "var f: ([x, y,]: number[]) => boolean", |
| + "var f: ([x, y,,]: number[]) => boolean", |
| + "var f: ([x, [a, b, c], z]: [number, any[], string]) => boolean", |
| + "var f: ({x: a, y: b}: {x: number, y: string}) => boolean", |
| + "var f: ({x: a, y: [b, c, ...rest]}: {x: number, y: string[]}) => boolean", |
| + "var f: ({x: {a, b}, y: c}: {x: {a, b}, y: string}) => boolean", |
| + NULL |
| + }; |
| + |
| + const char* error_data[] = { |
| + "var f: ({x: {a; b}, y: c}: {x: {a; b}, y: string}) => boolean", |
| + NULL |
| + }; |
| + |
| + static const ParserFlag always_flags[] = {kAllowTypes}; |
| + RunParserSyncTest(untyped_context_data, correct_data, kError, NULL, 0, |
| + always_flags, arraysize(always_flags)); |
| + RunParserSyncTest(typed_context_data, correct_data, kSuccess, NULL, 0, |
| + always_flags, arraysize(always_flags)); |
| + RunParserSyncTest(untyped_context_data, error_data, kError, NULL, 0, |
| + always_flags, arraysize(always_flags)); |
| + RunParserSyncTest(typed_context_data, error_data, kError, NULL, 0, |
| + always_flags, arraysize(always_flags)); |
| +} |