Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2012 the V8 project authors. All rights reserved. | 1 // Copyright 2012 the V8 project authors. All rights reserved. |
| 2 // Redistribution and use in source and binary forms, with or without | 2 // Redistribution and use in source and binary forms, with or without |
| 3 // modification, are permitted provided that the following conditions are | 3 // modification, are permitted provided that the following conditions are |
| 4 // met: | 4 // met: |
| 5 // | 5 // |
| 6 // * Redistributions of source code must retain the above copyright | 6 // * Redistributions of source code must retain the above copyright |
| 7 // notice, this list of conditions and the following disclaimer. | 7 // notice, this list of conditions and the following disclaimer. |
| 8 // * Redistributions in binary form must reproduce the above | 8 // * Redistributions in binary form must reproduce the above |
| 9 // copyright notice, this list of conditions and the following | 9 // copyright notice, this list of conditions and the following |
| 10 // disclaimer in the documentation and/or other materials provided | 10 // disclaimer in the documentation and/or other materials provided |
| (...skipping 7531 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 7542 static const ParserFlag always_flags[] = {kAllowTypes}; | 7542 static const ParserFlag always_flags[] = {kAllowTypes}; |
| 7543 RunParserSyncTest(untyped_context_data, correct_data, kError, NULL, 0, | 7543 RunParserSyncTest(untyped_context_data, correct_data, kError, NULL, 0, |
| 7544 always_flags, arraysize(always_flags)); | 7544 always_flags, arraysize(always_flags)); |
| 7545 RunParserSyncTest(typed_context_data, correct_data, kSuccess, NULL, 0, | 7545 RunParserSyncTest(typed_context_data, correct_data, kSuccess, NULL, 0, |
| 7546 always_flags, arraysize(always_flags)); | 7546 always_flags, arraysize(always_flags)); |
| 7547 RunParserSyncTest(untyped_context_data, error_data, kError, NULL, 0, | 7547 RunParserSyncTest(untyped_context_data, error_data, kError, NULL, 0, |
| 7548 always_flags, arraysize(always_flags)); | 7548 always_flags, arraysize(always_flags)); |
| 7549 RunParserSyncTest(typed_context_data, error_data, kError, NULL, 0, | 7549 RunParserSyncTest(typed_context_data, error_data, kError, NULL, 0, |
| 7550 always_flags, arraysize(always_flags)); | 7550 always_flags, arraysize(always_flags)); |
| 7551 } | 7551 } |
| 7552 | |
| 7553 TEST(TypedModeObjectTypes) { | |
| 7554 const char* untyped_context_data[][2] = {{"", ""}, {NULL, NULL}}; | |
| 7555 const char* typed_context_data[][2] = {{"'use types'; ", ""}, {NULL, NULL}}; | |
| 7556 | |
| 7557 const char* correct_data[] = { | |
| 7558 "var x: {}", | |
| 7559 "var x: {a}", | |
| 7560 "var x: {a, b}", | |
| 7561 "var x: {a, b?, c}", | |
| 7562 "var x: {a: number}", | |
| 7563 "var x: {a: number, b: string}", | |
| 7564 "var x: {a?: number; b: {c: any}}", | |
| 7565 "var x: {f()}", | |
| 7566 "var x: {f() : number}", | |
| 7567 "var x: {f(a, b)}", | |
| 7568 "var x: {f(a: number, b: string)}", | |
| 7569 "var x: {f(a: number, b: string) : boolean}", | |
| 7570 "var x: {f?(a: number, b: string) : boolean}", | |
| 7571 "var x: {f<A extends number>(a: A, b: string) : boolean}", | |
|
rossberg
2016/04/07 15:09:02
Perhaps add a case without extends clause.
nickie
2016/04/08 09:50:57
Done.
| |
| 7572 "var x: {f?<A extends number>(a: A, b: string) : boolean}", | |
| 7573 "var x: {()}", | |
| 7574 "var x: {() : number}", | |
| 7575 "var x: {(a, b)}", | |
| 7576 "var x: {(a: number, b: string)}", | |
| 7577 "var x: {(a: number, b: string) : boolean}", | |
| 7578 "var x: {<A extends number>(a: A, b: string) : boolean}", | |
| 7579 "var x: {new (a, b)}", | |
| 7580 "var x: {new (a: number, b: string)}", | |
| 7581 "var x: {new (a: number, b: string) : boolean}", | |
| 7582 "var x: {new <A extends number>(a: A, b: string) : boolean}", | |
| 7583 NULL | |
| 7584 }; | |
| 7585 | |
| 7586 const char* error_data[] = { | |
| 7587 "var z: {a: ()}", // Not valid in general. | |
| 7588 "var z: {a: []}", // Valid as a binding pattern, not as a type. | |
|
rossberg
2016/04/07 15:09:02
Perhaps add things like
f<>()
f<A>
f<A>: A
nickie
2016/04/08 09:50:57
Done.
| |
| 7589 NULL | |
| 7590 }; | |
| 7591 | |
| 7592 static const ParserFlag always_flags[] = {kAllowTypes}; | |
| 7593 RunParserSyncTest(untyped_context_data, correct_data, kError, NULL, 0, | |
| 7594 always_flags, arraysize(always_flags)); | |
| 7595 RunParserSyncTest(typed_context_data, correct_data, kSuccess, NULL, 0, | |
| 7596 always_flags, arraysize(always_flags)); | |
| 7597 RunParserSyncTest(untyped_context_data, error_data, kError, NULL, 0, | |
| 7598 always_flags, arraysize(always_flags)); | |
| 7599 RunParserSyncTest(typed_context_data, error_data, kError, NULL, 0, | |
| 7600 always_flags, arraysize(always_flags)); | |
| 7601 } | |
| 7602 | |
| 7603 TEST(TypedModeBindingPatterns) { | |
| 7604 const char* untyped_context_data[][2] = {{"", ""}, {NULL, NULL}}; | |
| 7605 const char* typed_context_data[][2] = {{"'use types'; ", ""}, {NULL, NULL}}; | |
| 7606 | |
| 7607 const char* correct_data[] = { | |
| 7608 "var f: (x: number, cmd?: 'two', ...rest) => string", | |
| 7609 "var f: ([]: number[]) => boolean", | |
| 7610 "var f: ([x, y]: number[]) => boolean", | |
| 7611 "var f: ([x, ...rest]: number[]) => boolean", | |
| 7612 "var f: ([,x, y]: number[]) => boolean", | |
| 7613 "var f: ([x, y,]: number[]) => boolean", | |
| 7614 "var f: ([x, y,,]: number[]) => boolean", | |
| 7615 "var f: ([x, [a, b, c], z]: [number, any[], string]) => boolean", | |
| 7616 "var f: ({x: a, y: b}: {x: number, y: string}) => boolean", | |
| 7617 "var f: ({x: a, y: [b, c, ...rest]}: {x: number, y: string[]}) => boolean", | |
| 7618 "var f: ({x: {a, b}, y: c}: {x: {a, b}, y: string}) => boolean", | |
| 7619 NULL | |
| 7620 }; | |
| 7621 | |
| 7622 const char* error_data[] = { | |
| 7623 "var f: ({x: {a; b}, y: c}: {x: {a; b}, y: string}) => boolean", | |
| 7624 NULL | |
| 7625 }; | |
| 7626 | |
| 7627 static const ParserFlag always_flags[] = {kAllowTypes}; | |
| 7628 RunParserSyncTest(untyped_context_data, correct_data, kError, NULL, 0, | |
| 7629 always_flags, arraysize(always_flags)); | |
| 7630 RunParserSyncTest(typed_context_data, correct_data, kSuccess, NULL, 0, | |
| 7631 always_flags, arraysize(always_flags)); | |
| 7632 RunParserSyncTest(untyped_context_data, error_data, kError, NULL, 0, | |
| 7633 always_flags, arraysize(always_flags)); | |
| 7634 RunParserSyncTest(typed_context_data, error_data, kError, NULL, 0, | |
| 7635 always_flags, arraysize(always_flags)); | |
| 7636 } | |
| OLD | NEW |