Add parsing for object types

Add parsing for object types

This patch also turns function/constructor types into syntactic sugar.

This is based on https://codereview.chromium.org/1810943002

R=rossberg@chromium.org
BUG=
NOTRY=true
NOPRESUBMIT=true

[rossberg, 2016-04-07 15:09:02]

LGTM, only nits and a couple test.

https://codereview.chromium.org/1817093002/diff/1/src/ast/ast.h
File src/ast/ast.h (right):

https://codereview.chromium.org/1817093002/diff/1/src/ast/ast.h#newcode3230
src/ast/ast.h:3230: bool optional() const { return optional_; }
Nit: is_optional, is_constructor?

https://codereview.chromium.org/1817093002/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/1817093002/diff/1/test/cctest/test-parsing.cc...
test/cctest/test-parsing.cc:7571: "var x: {f<A extends number>(a: A, b: string)
: boolean}",
Perhaps add a case without extends clause.

https://codereview.chromium.org/1817093002/diff/1/test/cctest/test-parsing.cc...
test/cctest/test-parsing.cc:7588: "var z: {a: []}",  // Valid as a binding
pattern, not as a type.
Perhaps add things like

f<>()
f<A>
f<A>: A

https://codereview.chromium.org/1817093002/diff/1/test/mjsunit/harmony/typesy...
File test/mjsunit/harmony/typesystem/typegen.js (right):

https://codereview.chromium.org/1817093002/diff/1/test/mjsunit/harmony/typesy...
test/mjsunit/harmony/typesystem/typegen.js:273: t => "{f<A extends " + t + ">(a:
" + t + ")}",
How about cases without extends, or with more than one parameter?

[nickie, 2016-04-08 09:50:57]

Bug fix required: always require formal parameters after type parameters.

https://codereview.chromium.org/1817093002/diff/1/src/ast/ast.h
File src/ast/ast.h (right):

https://codereview.chromium.org/1817093002/diff/1/src/ast/ast.h#newcode3230
src/ast/ast.h:3230: bool optional() const { return optional_; }
On 2016/04/07 15:09:02, rossberg wrote:
> Nit: is_optional, is_constructor?

Done.

https://codereview.chromium.org/1817093002/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/1817093002/diff/1/test/cctest/test-parsing.cc...
test/cctest/test-parsing.cc:7571: "var x: {f<A extends number>(a: A, b: string)
: boolean}",
On 2016/04/07 15:09:02, rossberg wrote:
> Perhaps add a case without extends clause.

Done.

https://codereview.chromium.org/1817093002/diff/1/test/cctest/test-parsing.cc...
test/cctest/test-parsing.cc:7588: "var z: {a: []}",  // Valid as a binding
pattern, not as a type.
On 2016/04/07 15:09:02, rossberg wrote:
> Perhaps add things like
> 
> f<>()
> f<A>
> f<A>: A

Done.

https://codereview.chromium.org/1817093002/diff/1/test/mjsunit/harmony/typesy...
File test/mjsunit/harmony/typesystem/typegen.js (right):

https://codereview.chromium.org/1817093002/diff/1/test/mjsunit/harmony/typesy...
test/mjsunit/harmony/typesystem/typegen.js:273: t => "{f<A extends " + t + ">(a:
" + t + ")}",
On 2016/04/07 15:09:02, rossberg wrote:
> How about cases without extends, or with more than one parameter?

Done.

[rossberg, 2016-04-08 10:47:41]

lgtm

[nickie, 2016-04-08 11:40:38]

Patchset #2 landed MANUALLY in experimental/nikolaos/types as:
273195d6e6f5c6a183c00129c2fd0afd890c7405
https://chromium.googlesource.com/v8/v8/+/273195d6e6f5c6a183c00129c2fd0afd890...

[nickie, 2016-04-08 11:40:51]

Description was changed from

==========
Add parsing for object types

This patch also turns function/constructor types into syntactic sugar.

This is based on https://codereview.chromium.org/1810943002

R=rossberg@chromium.org
BUG=
NOTRY=true
NOPRESUBMIT=true
==========

to

==========
Add parsing for object types

This patch also turns function/constructor types into syntactic sugar.

This is based on https://codereview.chromium.org/1810943002

R=rossberg@chromium.org
BUG=
NOTRY=true
NOPRESUBMIT=true
==========