Issue 181703003: Factory methods for heap-allocated SkAnnotation objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 181703003: Factory methods for heap-allocated SkAnnotation objects. (Closed)

Created:
6 years, 10 months ago by Dominik Grewe

Modified:
6 years, 9 months ago

Reviewers:
scroggo, mtklein, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Factory methods for heap-allocated SkAnnotation objects. This is part of an effort to ensure that all SkPaint effects can only be allocated on the heap. This patch makes the constructors of SkAnnotation non-public and instead provides factory methods for creating these objects on the heap. BUG=skia:2187 Committed: http://code.google.com/p/skia/source/detail?r=13605

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -6 lines)			Patch
M	include/core/SkAnnotation.h	View	1 chunk	+11 lines, -2 lines	0 comments	Download
M	src/core/SkAnnotation.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkPaint.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pipe/SkGPipeRead.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Dominik Grewe

Afaict SkAnnotation isn't used anywhere in Chrome/Blink or Android, so I've not used any guards ...

6 years, 10 months ago (2014-02-26 18:38:02 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/dominikg@chromium.org/181703003/1

6 years, 9 months ago (2014-02-27 11:34:03 UTC) #5

Message was sent while issue was closed.

Change committed as 13605

Expand Messages | Collapse Messages