src/core/SkAnnotation.cpp - Issue 181703003: Factory methods for heap-allocated SkAnnotation objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkAnnotation.cpp

Issue 181703003: Factory methods for heap-allocated SkAnnotation objects. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkAnnotation.cpp

diff --git a/src/core/SkAnnotation.cpp b/src/core/SkAnnotation.cpp

index 6ba645ffed578dd940a7ec2fd9ae0e532b034a50..bddff64db84c6dff3dcd200f6942a5848e27bd1d 100644

--- a/src/core/SkAnnotation.cpp

+++ b/src/core/SkAnnotation.cpp

@@ -56,7 +56,7 @@ const char* SkAnnotationKeys::Link_Named_Dest_Key() {

#include "SkCanvas.h"

static void annotate_paint(SkPaint& paint, const char* key, SkData* value) {

- paint.setAnnotation(SkNEW_ARGS(SkAnnotation, (key, value)))->unref();

+ paint.setAnnotation(SkAnnotation::Create(key, value))->unref();

}

void SkAnnotateRectWithURL(SkCanvas* canvas, const SkRect& rect, SkData* value) {

« no previous file with comments | « include/core/SkAnnotation.h ('k') | src/core/SkPaint.cpp » ('j') | no next file with comments »