Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1817003002: Revert to using ForceSet for installing the document property for now (Closed)

Created:
4 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 9 months ago
Reviewers:
haraken, Toon Verwaest
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert to using ForceSet for installing the document property for now Depends on https://codereview.chromium.org/1816033002 BUG=595601 R=verwaest@chromium.org Committed: https://crrev.com/3b8fd0235bcbb1088d9a3660d581ebfdc161f953 Cr-Commit-Position: refs/heads/master@{#382292}

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
jochen (gone - plz use gerrit)
4 years, 9 months ago (2016-03-21 06:17:50 UTC) #1
Toon Verwaest
lgtm
4 years, 9 months ago (2016-03-21 07:30:26 UTC) #2
haraken
LGTM
4 years, 9 months ago (2016-03-21 08:04:41 UTC) #3
haraken
Shall we add a TODO?
4 years, 9 months ago (2016-03-21 08:05:19 UTC) #4
jochen (gone - plz use gerrit)
done
4 years, 9 months ago (2016-03-21 13:18:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817003002/20001
4 years, 9 months ago (2016-03-21 13:18:18 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-21 15:25:48 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 15:27:26 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3b8fd0235bcbb1088d9a3660d581ebfdc161f953
Cr-Commit-Position: refs/heads/master@{#382292}

Powered by Google App Engine
This is Rietveld 408576698