Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1273)

Issue 1816033002: Temporarily undeprecate ForceSet (Closed)

Created:
4 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Temporarily undeprecate ForceSet I first need to figure out what to do about window.document before we can deprecate this: window.document is a regular accessor, however, once the window navigated from about:blank, its value will never change. Blink uses ForceSet to then replace the accessor with a data constant which has way better performance than invoking the accessor all the time. Since the accessor, however, is installed as read only & non-configurable, there is no spec compliant way to pull this off right now BUG=chromium:595601 R=verwaest@chromium.org LOG=y Committed: https://crrev.com/2a1570ef1a92f2622418330a1e088f0a5d869fed Cr-Commit-Position: refs/heads/master@{#34919}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M include/v8.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
4 years, 9 months ago (2016-03-21 06:17:04 UTC) #1
Toon Verwaest
sadness lgtm
4 years, 9 months ago (2016-03-21 07:30:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816033002/1
4 years, 9 months ago (2016-03-21 07:35:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 07:52:12 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 07:53:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a1570ef1a92f2622418330a1e088f0a5d869fed
Cr-Commit-Position: refs/heads/master@{#34919}

Powered by Google App Engine
This is Rietveld 408576698