Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1816963002: Use TemporaryChange in HTMLTitleElement::setText (Closed)

Created:
4 years, 9 months ago by hyunjunekim2
Modified:
4 years, 9 months ago
Reviewers:
davve, pdr., fs
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use TemporaryChange in HTMLTitleElement::setText Apply TemporaryChange that switch the value using scope. Committed: https://crrev.com/0acf72afdddec2146df0cd04762a7128b993c929 Cr-Commit-Position: refs/heads/master@{#382290}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M third_party/WebKit/Source/core/html/HTMLTitleElement.cpp View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
hyunjunekim2
Could you check this one that clean up codes? Thank you.
4 years, 9 months ago (2016-03-21 04:49:14 UTC) #5
davve
Code change lgtm Is this part of a bigger effort to introduce TemporaryChange in more/all ...
4 years, 9 months ago (2016-03-21 07:30:25 UTC) #6
hyunjunekim2
On 2016/03/21 07:30:25, David Vest wrote: > Code change lgtm > > Is this part ...
4 years, 9 months ago (2016-03-21 09:42:45 UTC) #7
davve
On 2016/03/21 09:42:45, hyunjunekim2 wrote: > On 2016/03/21 07:30:25, David Vest wrote: > > Code ...
4 years, 9 months ago (2016-03-21 09:47:33 UTC) #8
hyunjunekim2
David Vest, May i land this patch?
4 years, 9 months ago (2016-03-21 10:55:13 UTC) #9
davve
On 2016/03/21 10:55:13, hyunjunekim2 wrote: > David Vest, > May i land this patch? I ...
4 years, 9 months ago (2016-03-21 11:16:45 UTC) #10
hyunjunekim2
On 2016/03/21 11:16:45, David Vest wrote: > On 2016/03/21 10:55:13, hyunjunekim2 wrote: > > David ...
4 years, 9 months ago (2016-03-21 12:17:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816963002/1
4 years, 9 months ago (2016-03-21 12:17:37 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 15:23:59 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 15:25:39 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0acf72afdddec2146df0cd04762a7128b993c929
Cr-Commit-Position: refs/heads/master@{#382290}

Powered by Google App Engine
This is Rietveld 408576698