Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1816963002:
Use TemporaryChange in HTMLTitleElement::setText (Closed)
|
Created:
4 years, 9 months ago by hyunjunekim2 Modified:
4 years, 9 months ago CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse TemporaryChange in HTMLTitleElement::setText
Apply TemporaryChange that switch the value using scope.
Committed: https://crrev.com/0acf72afdddec2146df0cd04762a7128b993c929
Cr-Commit-Position: refs/heads/master@{#382290}
Patch Set 1 #
Messages
Total messages: 17 (7 generated)
Description was changed from ========== Use TemporaryChange in HTMLTitleElement::setTitleElement Use TemporaryChange in HTMLTitleElement::setTitleElement ========== to ========== Use TemporaryChange in HTMLTitleElement::setText Use TemporaryChange in HTMLTitleElement::setText ==========
hyunjune.kim@samsung.com changed reviewers: + davve@opera.com, fs@opera.com, pdr@chromium.org
Description was changed from ========== Use TemporaryChange in HTMLTitleElement::setText Use TemporaryChange in HTMLTitleElement::setText ========== to ========== Use TemporaryChange in HTMLTitleElement::setText ==========
Description was changed from ========== Use TemporaryChange in HTMLTitleElement::setText ========== to ========== Use TemporaryChange in HTMLTitleElement::setText Apply TemporaryChange that switch the value using scope. ==========
Could you check this one that clean up codes? Thank you.
Code change lgtm Is this part of a bigger effort to introduce TemporaryChange in more/all relevant places in Blink? And if so, is there a tracking bug for overall progress you can provide in the description?
On 2016/03/21 07:30:25, David Vest wrote: > Code change lgtm > > Is this part of a bigger effort to introduce TemporaryChange in more/all > relevant places in Blink? Latest i landed a patch(https://codereview.chromium.org/1774913003/patch/260001/270006). that is similar. Could you check this one? Thanks >And if so, is there a tracking bug for overall progress you can provide in the description? I guess that there isn't. I searched monorail tracker. https://bugs.chromium.org/p/chromium/issues/list?can=1&q=summary%3ATemporaryC...
On 2016/03/21 09:42:45, hyunjunekim2 wrote: > On 2016/03/21 07:30:25, David Vest wrote: > > Code change lgtm > > > > Is this part of a bigger effort to introduce TemporaryChange in more/all > > relevant places in Blink? > > Latest i landed a > patch(https://codereview.chromium.org/1774913003/patch/260001/270006). > that is similar. Could you check this one? Thanks Right, it makes sense to align the two. Thanks.
David Vest, May i land this patch?
On 2016/03/21 10:55:13, hyunjunekim2 wrote: > David Vest, > May i land this patch? I have nothing further. It's fine to land for me.
On 2016/03/21 11:16:45, David Vest wrote: > On 2016/03/21 10:55:13, hyunjunekim2 wrote: > > David Vest, > > May i land this patch? > > I have nothing further. It's fine to land for me. Thank you, go ahead. :)
The CQ bit was checked by hyunjune.kim@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816963002/1
Message was sent while issue was closed.
Description was changed from ========== Use TemporaryChange in HTMLTitleElement::setText Apply TemporaryChange that switch the value using scope. ========== to ========== Use TemporaryChange in HTMLTitleElement::setText Apply TemporaryChange that switch the value using scope. ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Use TemporaryChange in HTMLTitleElement::setText Apply TemporaryChange that switch the value using scope. ========== to ========== Use TemporaryChange in HTMLTitleElement::setText Apply TemporaryChange that switch the value using scope. Committed: https://crrev.com/0acf72afdddec2146df0cd04762a7128b993c929 Cr-Commit-Position: refs/heads/master@{#382290} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/0acf72afdddec2146df0cd04762a7128b993c929 Cr-Commit-Position: refs/heads/master@{#382290} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
