Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLTitleElement.cpp

Issue 1816963002: Use TemporaryChange in HTMLTitleElement::setText (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2003, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2003, 2010 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 } 75 }
76 76
77 return result.toString(); 77 return result.toString();
78 } 78 }
79 79
80 void HTMLTitleElement::setText(const String &value) 80 void HTMLTitleElement::setText(const String &value)
81 { 81 {
82 RefPtrWillBeRawPtr<Node> protectFromMutationEvents(this); 82 RefPtrWillBeRawPtr<Node> protectFromMutationEvents(this);
83 ChildListMutationScope mutation(*this); 83 ChildListMutationScope mutation(*this);
84 84
85 // Avoid calling Document::setTitleElement() during intermediate steps. 85 {
86 m_ignoreTitleUpdatesWhenChildrenChange = !value.isEmpty(); 86 // Avoid calling Document::setTitleElement() during intermediate steps.
87 removeChildren(OmitSubtreeModifiedEvent); 87 TemporaryChange<bool> inhibitTitleUpdateScope(m_ignoreTitleUpdatesWhenCh ildrenChange, !value.isEmpty());
88 m_ignoreTitleUpdatesWhenChildrenChange = false; 88 removeChildren(OmitSubtreeModifiedEvent);
89 }
89 90
90 if (!value.isEmpty()) 91 if (!value.isEmpty())
91 appendChild(document().createTextNode(value.impl()), IGNORE_EXCEPTION); 92 appendChild(document().createTextNode(value.impl()), IGNORE_EXCEPTION);
92 } 93 }
93 94
94 } // namespace blink 95 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698