Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1816703002: Mojo C++ bindings: assume that all imported mojoms have the same variant as current mojom (Closed)

Created:
4 years, 9 months ago by yzshen1
Modified:
4 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, tfarina, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: assume that all imported mojoms have the same variant as current mojom. This CL also disable struct_traits_unittest because variant+typemap is not supported currently. BUG=596202, 596162 Committed: https://crrev.com/aef38024a1d6d99deb565a89cd7dd8b3bc21f971 Cr-Commit-Position: refs/heads/master@{#382143}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -28 lines) Patch
M mojo/mojo_edk_tests.gyp View 1 2 chunks +4 lines, -3 lines 0 comments Download
M mojo/mojo_public.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/BUILD.gn View 1 2 chunks +6 lines, -3 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/blink_test.typemap View 1 1 chunk +6 lines, -6 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/chromium_test.typemap View 1 1 chunk +6 lines, -6 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/test_native_types.mojom View 1 2 chunks +6 lines, -5 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/test_variant.mojom View 1 chunk +7 lines, -0 lines 0 comments Download
A + mojo/public/interfaces/bindings/tests/test_variant_import.mojom View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module-internal.h.tmpl View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_declaration.tmpl View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/mojom_cpp_generator.py View 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
yzshen1
Hi, Ken. Please take a look. Thanks!
4 years, 9 months ago (2016-03-18 22:43:29 UTC) #3
Ken Rockot(use gerrit already)
lgtm
4 years, 9 months ago (2016-03-18 23:17:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816703002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816703002/20001
4 years, 9 months ago (2016-03-18 23:24:51 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-19 00:34:48 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-19 00:37:10 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aef38024a1d6d99deb565a89cd7dd8b3bc21f971
Cr-Commit-Position: refs/heads/master@{#382143}

Powered by Google App Engine
This is Rietveld 408576698