mojo/public/interfaces/bindings/tests/test_native_types.mojom - Issue 1816703002: Mojo C++ bindings: assume that all imported mojoms have the same variant as current mojom

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/interfaces/bindings/tests/test_native_types.mojom

Issue 1816703002: Mojo C++ bindings: assume that all imported mojoms have the same variant as current mojom (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/interfaces/bindings/tests/chromium_test.typemap ('k') | mojo/public/interfaces/bindings/tests/test_variant.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/interfaces/bindings/tests/test_native_types.mojom

diff --git a/mojo/public/interfaces/bindings/tests/test_native_types.mojom b/mojo/public/interfaces/bindings/tests/test_native_types.mojom

index ddb88cf97c36b801ddc92b39d31001e005a32a61..3fceddefce0188686260feb4ea3a9c5b2ee9614b 100644

--- a/mojo/public/interfaces/bindings/tests/test_native_types.mojom

+++ b/mojo/public/interfaces/bindings/tests/test_native_types.mojom

@@ -4,7 +4,7 @@

module mojo.test;

-import "mojo/public/interfaces/bindings/tests/rect.mojom";

+// import "mojo/public/interfaces/bindings/tests/rect.mojom";

// Used to verify that structs can be declared with no body in mojom.

@@ -23,10 +23,11 @@ interface PicklePasser {

=> (array<array<PickledStruct>> passed);

};

+// TODO: crbug.com/596202

// Used to verify support for native serialization of mojom-defined structs

// using StrucTraits with different variants of the Rect type from rect.mojom.

-interface RectService {

- AddRect(Rect r);

- GetLargestRect() => (Rect largest);

-};

+// interface RectService {

+// AddRect(Rect r);

+// GetLargestRect() => (Rect largest);

+// };